Skip to content

๐Ÿงฉ KRDS ์ปดํฌ๋„ŒํŠธ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ (๋ฐ”๋‹๋ผ HTML/CSS ๊ตฌํ˜„์ฒด) - #52

Merged
seonghobae merged 3 commits into
mainfrom
feat/krds-component-library
Jul 11, 2026
Merged

๐Ÿงฉ KRDS ์ปดํฌ๋„ŒํŠธ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ (๋ฐ”๋‹๋ผ HTML/CSS ๊ตฌํ˜„์ฒด)#52
seonghobae merged 3 commits into
mainfrom
feat/krds-component-library

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๋ฌด์—‡์„

Figma ๋””์ž์ธ ์‹œ์Šคํ…œ(6Kx2gzcduyIyLGN3Ck2rtm)์˜ ์ปดํฌ๋„ŒํŠธ๋ฅผ ์‹ค์ œ ์ฝ”๋“œ ๊ตฌํ˜„์ฒด๋กœ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค. ์ง€๊ธˆ๊นŒ์ง€ ์ปดํฌ๋„ŒํŠธ๋Š” Figma์—๋งŒ ์žˆ์—ˆ๊ณ  ๋Œ€์‘ ์ฝ”๋“œ๊ฐ€ ์—†์–ด component-level parity๋ฅผ ์‹ค์ธกํ•  ์ˆ˜ ์—†์—ˆ๋Š”๋ฐ, ์ด PR๋กœ ์‹ค์ œ ๊ตฌํ˜„์ด ์ƒ๊น๋‹ˆ๋‹ค.

์–ด๋–ป๊ฒŒ (์Šค์ฝ”ํ”„ ๊ฒฐ์ •)

๋ฐ”๋‹๋ผ ์ •์  ์‚ฌ์ดํŠธ๋ผ Storybook + JS ํ”„๋ ˆ์ž„์›Œํฌ๋Š” ๊ณผ์„ค๊ณ„ โ†’ ๋นŒ๋“œ/ํ”„๋ ˆ์ž„์›Œํฌ ์—†๋Š” ๋ฐ”๋‹๋ผ HTML/CSS ๊ฐค๋Ÿฌ๋ฆฌ๋กœ ๊ตฌํ˜„. ๊ธฐ์กด styles.css์˜ ๋ธŒ๋žœ๋“œ ํ† ํฐ(:root)์„ ๊ทธ๋Œ€๋กœ ์†Œ๋น„ํ•˜๊ณ , KRDS status ์ƒ‰์ƒ(info/success/warning/danger)๋งŒ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค.

ํŒŒ์ผ

  • components/krds-components.css โ€” Button, Text Input, Checkbox/Radio, Select, Badge, Tag, Tabs, Accordion(native <details>), Pagination, Alert, Toast. ์ „๋ถ€ ํ† ํฐ ๋ฐ”์ธ๋”ฉ, focus-visible๋Š” ์‚ฌ์ดํŠธ ์ปจ๋ฒค์…˜(teal 2px offset 2px) ์ค€์ˆ˜.
  • components/index.html โ€” 10๊ฐœ story ๊ฐค๋Ÿฌ๋ฆฌ(states ํฌํ•จ). Tabs/Tag ์ตœ์†Œ ๋™์ž‘ JS(ํ”„๋ ˆ์ž„์›Œํฌ ์—†์Œ).
  • .gitignore โ€” ๋กœ์ปฌ codegraph ์ธ๋ฑ์Šค ์ œ์™ธ.

๊ฒ€์ฆ (Puppeteer @1200w, ์‹ค์ธก)

Component ์ธก์ • ๋น„๊ณ 
primary button 98ร—51, radius 4px, min-h 48px, bg #16263d ์‚ฌ์ดํŠธ .button ์ปจ๋ฒค์…˜ + Figma ์ŠคํŽ™ ์ผ์น˜
text input radius 4px, min-h 48px, border --line
badge success bg #eaf5eb / text #2e7d32
toast radius 12px, bg #16263d
ํ•ฉ๊ณ„ 10 stories ยท 37 component instances ๋ Œ๋”

๋˜๋Œ๋ฆฌ๊ธฐ

์ƒˆ components/ ๋””๋ ‰ํ„ฐ๋ฆฌ๋งŒ ์ถ”๊ฐ€ โ€” ๊ธฐ์กด ํŽ˜์ด์ง€/์Šคํƒ€์ผ ๋ณ€๊ฒฝ 0. ์•ˆ์ „ํ•˜๊ฒŒ revert ๊ฐ€๋Šฅ.

๋ฏธ๋ฆฌ๋ณด๊ธฐ: /components/ (GitHub Pages ๋ฐฐํฌ ์‹œ ๋ฐ”๋กœ ์ ‘๊ทผ)

๐Ÿค– Generated with Claude Code

https://claude.ai/code/session_0169KuM8Ygfmeswa4EtaL7mC

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@opencode-agent

opencode-agent Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 843198c7601313a8a3c7080edcd49a911f705879
  • Workflow run: 29133321594
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including LICENSE, components/index.html, components/krds-components.css.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports test coverage as not applicable because no supported changed source files or package manifests were found.
Docstring coverage: coverage execution evidence reports docstring coverage as not applicable because no supported changed source files or package manifests were found.
DAG: CodeGraph/source-backed behavior map connects LICENSE to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: No blocking issues found; changes are isolated to components directory with no unresolved review threads or failed checks.
  • Head SHA: 843198c7601313a8a3c7080edcd49a911f705879
  • Workflow run: 29133321594
  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (4 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (4 files)"]
  R1 --> V1["required checks"]
Loading

Figma ๋””์ž์ธ ์‹œ์Šคํ…œ(6Kx2gzcduyIyLGN3Ck2rtm)์˜ ์ปดํฌ๋„ŒํŠธ๋ฅผ ์‹ค์ œ ์ฝ”๋“œ๋กœ ๊ตฌํ˜„.
๊ธฐ์กด ๋ธŒ๋žœ๋“œ ํ† ํฐ(:root)์„ ์†Œ๋น„ํ•˜๊ณ  KRDS status ํ† ํฐ๋งŒ ์ถ”๊ฐ€. ๋นŒ๋“œ/ํ”„๋ ˆ์ž„์›Œํฌ
์—†์ด GitHub Pages์—์„œ ๋ฐ”๋กœ ์„œ๋น™๋˜๋Š” component gallery.

- components/krds-components.css: Button/Input/Checkbox/Radio/Select/Badge/Tag/
  Tabs/Accordion(native details)/Pagination/Alert/Toast โ€” ํ† ํฐ ๋ฐ”์ธ๋”ฉ, focus-visible(teal 2px)
- components/index.html: 10๊ฐœ story ๊ฐค๋Ÿฌ๋ฆฌ(states ํฌํ•จ), ํ”„๋ ˆ์ž„์›Œํฌ ์—†๋Š” tabs/tag JS
- .gitignore: ๋กœ์ปฌ codegraph ์ธ๋ฑ์Šค ์ œ์™ธ

์›๋ž˜ ์ด ๋ธŒ๋žœ์น˜์— ํ•จ๊ป˜ ์žˆ๋˜ styles.css ํ™ˆํŽ˜์ด์ง€ ๊ฐœ์„ (dikw eyebrow ๋Œ€๋น„, content-visibility)์€
#53ยท#54๋กœ main์— ๋…๋ฆฝ ๋จธ์ง€๋˜์–ด ์ค‘๋ณต ์ œ๊ฑฐํ•จ. ์ด PR์€ components/ ์ปดํฌ๋„ŒํŠธ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋งŒ ๋‹ด์Œ.
ํ˜„์žฌ main ์œ„๋กœ rebaseํ•˜์—ฌ ์ถฉ๋Œ ํ•ด์†Œ.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0169KuM8Ygfmeswa4EtaL7mC
@seonghobae
seonghobae force-pushed the feat/krds-component-library branch from a98e988 to b6eb389 Compare July 7, 2026 05:33
@seonghobae

Copy link
Copy Markdown
Contributor Author

Remediation summary

๋ชจ๋“  ํ•„์ˆ˜ ์ฒดํฌ(coverage-evidence, trivy-fs, osv-scan, scorecard, strix, dependency-review ๋“ฑ)๋Š” ํ†ต๊ณผ ์ƒํƒœ์ด๋ฉฐ, ๋ฏธํ•ด๊ฒฐ ๋ฆฌ๋ทฐ ์ฝ”๋ฉ˜ํŠธ๋‚˜ CHANGES_REQUESTED ๋Š” ์—†์Šต๋‹ˆ๋‹ค. ์ฝ”๋“œ ๋ณ€๊ฒฝ ๋ถˆํ•„์š” โ€” components/ ๋””๋ ‰ํ„ฐ๋ฆฌ๋งŒ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒฉ๋ฆฌ๋œ ๋ณ€๊ฒฝ์ž…๋‹ˆ๋‹ค.

์ด์ „์— opencode-review ๊ฐ€ SHA a98e988 ์—์„œ APPROVE ํ•œ ์ด๋ ฅ์ด ์žˆ์œผ๋ฉฐ, ํ˜„์žฌ head(b6eb389)๋Š” main ๋ฆฌ๋ฒ ์ด์Šค ํ›„ ์‹ค์งˆ ๋‚ด์šฉ ๋™์ผํ•ฉ๋‹ˆ๋‹ค.

๋‚จ์€ ํ•ญ๋ชฉ: ํ˜„์žฌ head ์˜ opencode-review ๋งŒ ์‹คํŒจ โ€” GitHub Models ๋ชจ๋ธ ํ’€ ํƒ€์ž„์•„์›ƒ(exit 124) + ๋Ÿฌ๋„ˆ ํ ์ ์ฒด๋กœ ์ธํ•œ org-infra ์ด์Šˆ์ž…๋‹ˆ๋‹ค. ์‹คํŒจ ์žก ์žฌ์‹คํ–‰(attempt 2)์„ ํŠธ๋ฆฌ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including LICENSE, components/index.html, components/krds-components.css.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports test coverage as not applicable because no supported changed source files or package manifests were found.
Docstring coverage: coverage execution evidence reports docstring coverage as not applicable because no supported changed source files or package manifests were found.
DAG: CodeGraph/source-backed behavior map connects LICENSE to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: No blocking issues found; changes are isolated to components directory with no unresolved review threads or failed checks.
  • Head SHA: 843198c7601313a8a3c7080edcd49a911f705879
  • Workflow run: 29133321594
  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (4 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (4 files)"]
  R1 --> V1["required checks"]
Loading

@seonghobae
seonghobae merged commit a12c4f4 into main Jul 11, 2026
21 checks passed
@seonghobae
seonghobae deleted the feat/krds-component-library branch July 11, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants