fix(review): 사주 CalDAV 오프라인 Python 의존성 추가#594
Open
seonghobae wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the trusted, offline OpenCode coverage-evidence Python environment by adding a hash-pinned runtime dependency set needed to run ContextualWisdomLab/saju-caldav tests in a --network=none sandbox, while keeping the existing “install from trusted lock only” discipline.
Changes:
- Added a new contract test to ensure the newly trusted saju-caldav runtime dependencies are present as exact pins in the source requirements and are hash-locked in the generated lock file.
- Appended the required runtime dependency pins (bcrypt/FastAPI/HTTPX/iCalendar/korean-lunar-calendar) to
requirements-opencode-review-ci.txt. - Regenerated
requirements-opencode-review-ci-hashes.txtwith uv to include hashes for the expanded dependency closure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_opencode_python_dependency_lock.py | Adds a contract test enforcing that specific saju-caldav runtime pins are present and hash-locked (and that lunar-python is not). |
| requirements-opencode-review-ci.txt | Adds the trusted runtime pins required for offline saju-caldav test collection/execution. |
| requirements-opencode-review-ci-hashes.txt | Regenerated uv lock with hashes for the expanded trusted dependency set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+24
| assert requirement in source | ||
| locked_requirement = lock.split(requirement, 1)[1].split("\n", 1)[0] | ||
| assert locked_requirement.rstrip().endswith("\\") | ||
| assert "--hash=sha256:" in lock.split(requirement, 1)[1].split("\n# via", 1)[0] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
실패 근거
검증
Closes #593
Unblocks ContextualWisdomLab/saju-caldav#6