Update versions. Remove commons-lang:2.6. #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnc
commented
Oct 24, 2025
| return new HttpDownload( getUrl( resource ), getHttpLocation( resource.getLocation(), download ), target, | ||
| transferSizes, eventMetadata, http, mapper, metricRegistry, metricConfig, | ||
| globalProxyConfig.getEgressSites(), proxySitesCache ); | ||
| globalProxyConfig == null ? null : globalProxyConfig.getEgressSites(), proxySitesCache ); |
Contributor
Author
There was a problem hiding this comment.
If an HttpClientTransport was manually created the globalProxyConfig might be null so this needs a null check. Found this when testing the updated version against PME.
sswguo
reviewed
Oct 24, 2025
| import static org.hamcrest.MatcherAssert.assertThat; | ||
|
|
||
| @SuppressWarnings( "EmptyTryBlock" ) | ||
| @Ignore |
Member
There was a problem hiding this comment.
What's the reason to ignore this ?
Contributor
Author
There was a problem hiding this comment.
Oops apologies. I'd forgotten about that. I've removed it and removed the upgrade to cassandraUnitVersion which caused it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.