chore: bump ComfyUI to 0.20.2#1704
Conversation
📝 WalkthroughWalkthroughThis PR updates pinned versions of ChangesDependency and Version Updates
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
d9a3dae to
756024c
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
6-22: LGTM — version bumps are correct and internally consistent.
config.comfyUI.versiondrives thegit clone --branch v${version}inscripts/makeComfy.js, andconfig.frontend.versionindependently drivesdownloadFrontend.js(unaffected by the pip-side removal ofcomfyui-frontend-package).managerCommitcorrectly stays unchanged.One release-gate note: the PR description calls out that Desktop PR
#1694must merge before this one ships, as the new frontend path requires the updated missing-model download contract. Worth confirming#1694has landed before cutting the release build.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 6 - 22, This PR's package.json version/config bumps look correct; ensure the Desktop PR `#1694` has merged before releasing because the new frontend path relies on the updated missing-model download contract—verify that config.frontend.version and config.comfyUI.version are the intended release values and leave managerCommit unchanged, then confirm the Desktop change is merged and CI builds against these exact config values prior to cutting the release.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@package.json`:
- Around line 6-22: This PR's package.json version/config bumps look correct;
ensure the Desktop PR `#1694` has merged before releasing because the new frontend
path relies on the updated missing-model download contract—verify that
config.frontend.version and config.comfyUI.version are the intended release
values and leave managerCommit unchanged, then confirm the Desktop change is
merged and CI builds against these exact config values prior to cutting the
release.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f8f3715e-1df2-416d-a1b1-1ba0302dff63
📒 Files selected for processing (6)
assets/requirements/macos.compiledassets/requirements/windows_amd.compiledassets/requirements/windows_cpu.compiledassets/requirements/windows_nvidia.compiledpackage.jsonscripts/core-requirements.patch
Summary
0.8.36to0.9.00.20.1to0.20.2comfyui-workflow-templates==0.9.68Context
This is intentionally a minor desktop version bump rather than another patch release because the missing model downloader API surface changed. Desktop PR #1694 is expected to merge before this release and aligns the missing-model download contract that the newer frontend path depends on.
Notes
v0.20.2exists as the latest ComfyUI tag, though GitHub Releases still reportsv0.20.1as the latest published release.manager_requirements.txtis unchanged betweenv0.20.1andv0.20.2, somanagerCommitremains untouched.Checks
corepack yarn make:assetsassets/requirements/*.compiled, with unrelated resolver/index-source noise strippedcorepack yarn formatcorepack yarn lintcorepack yarn typecheckcorepack yarn test:unitSummary by CodeRabbit