NM-146: Port CatalogController to @RequestMapping(/catalog) with CRUD actions#160
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
… actions - Change @RequestMapping from / to /catalog per AC - Simplify sub-route paths (relative to class-level mapping) - Add root / redirect to /catalog via WebMvcConfig - Use RedirectAttributes to prevent model attribute leakage on redirects - Fix SessionInfoInterceptor to skip redirect views - Update all Thymeleaf templates to use /catalog base URLs - Update tests to verify /catalog routing and exact redirect URLs - Remove unused imports (spotless)
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the ASP.NET MVC
CatalogControllerto a Spring@Controllermapped to/catalog, aligning route paths with the acceptance criteria in NM-146.Key changes:
@RequestMappingfrom/to/catalog; simplified sub-route annotations to relative paths (/details/{id},/create,/edit/{id},/delete/{id})ViewControllerRegistryredirect from/→/cataloginWebMvcConfigfor backward compatibilityRedirectAttributesparameter to POST handlers to prevent@ControllerAdvice/interceptor model attributes from leaking as query params on redirects; fixedSessionInfoInterceptorto skip redirect viewsindex,details,create,edit,delete,error,layout) to use/catalogbase URLsCatalogControllerTest(15 tests) to use/catalogURLs and verify exact redirect targets; updatedSmokeTestto verify root redirect and/catalog200 response; spotless removed unused imports inPicControllerTestandCatalogServiceImplTestAll 82 tests pass. Spotless check passes.
Review & Testing Checklist for Human
/catalog,/catalog/details/{id},/catalog/create,/catalog/edit/{id},/catalog/delete/{id}/redirects to/catalog/catalogwithout stray query params/catalogNotes
SessionInfoInterceptorwas addingmachineNameandsessionStartTimeas query parameters on redirect URLs because it modified theModelAndViewmodel for all views including redirects. The fix skips model modification when the view is a redirect.PicControllerTest,CatalogServiceImplTest)Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/99dc603f5fd349e8963dc51876cec218