In case of unrecoverable exit code, display path of the failed script#83
Open
In case of unrecoverable exit code, display path of the failed script#83
Conversation
tjazerzen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personal remark: The code changes are kind off ugly and would prefer emitting the events that we do now in
render_machine/actions/*.pyinrender_machine/code_renderer.pyinstead.Why needed
We had the following bad UX:
Let's say out scripts exited with unrecoverable exit code.
We would:
But we didn't display the path to the failed script in the "testing status" widget.
This PR adds that for all of the scripts