Merged
Conversation
dusano
approved these changes
Feb 27, 2026
memory_management.py
Outdated
| return {}, {} | ||
| memory_files = file_utils.list_all_text_files(memory_path) | ||
| memory_files_content = file_utils.get_existing_files_content(memory_path, memory_files) | ||
| console.info(f"Loaded {len(memory_files_content)} memory files from {memory_path}.") |
Contributor
There was a problem hiding this comment.
I wouldn't include {memory_path}. Namley, this located in a hidden folder that we don't necessarily want to expose.
memory_management.py
Outdated
| # Not a valid JSON file, unlikely to be a valid memory file, delete it | ||
| os.remove(file_path) | ||
| os.remove(file_path) | ||
| console.info(f"Deleted unresolved memory file: {file_name}") |
Contributor
There was a problem hiding this comment.
I would set this on debug level (console.debug).
Please also change text to ”Deleted temporary memory file: {file_name}")
| continue | ||
| except (json.JSONDecodeError, OSError): | ||
| # Not a valid JSON file, unlikely to be a valid memory file, delete it | ||
| os.remove(file_path) |
Contributor
There was a problem hiding this comment.
I would add here console.error. This should not happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing unnecessary memory files that did not lead to a successful resolution of a test issue.