Conversation
pedjaradenkovic
requested changes
Feb 23, 2026
Contributor
pedjaradenkovic
left a comment
pedjaradenkovic
left a comment
There was a problem hiding this comment.
Functionality looks good but I would change some organisational things:
In render_utils the default SCRIPT_EXECUTION_TIMEOUT is used a couple of times which means that it would create wrong logs if some other timeout is used.
But this is just a consequence of the fact that execute script is called with optional timeout argument. I suggest you move those 120 as a default option into args parser and after that it will always have assigned value (in render_context and further in render_utils methods).
VitjanZ
force-pushed
the
feat/test_timeout_argument
branch
from
73222e2 to
3735786
Compare
Collaborator
Author
|
Verbally discussed the changes. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an argument to the client to set the test script timeout manually. This is necessary for projects with longer compilation times.