Skip to content

Fix for builds broken by Xcode 16 - #975

Closed
raulnor wants to merge 1 commit into
CocoaPods:masterfrom
raulnor:master
Closed

Fix for builds broken by Xcode 16#975
raulnor wants to merge 1 commit into
CocoaPods:masterfrom
raulnor:master

Conversation

@raulnor

@raulnor raulnor commented Oct 8, 2024

Copy link
Copy Markdown

I hope this format for the PR is okay, never contributed here before. I ran into this when our intern grouped the 3 files he was working on and broke builds. I rolled back the grouping in our project, but I wanted CocoaPods to be able to support it going forward.

Changes:

  • Add object version 70 to version map
  • Add support for new folder group type (PBXFileSystemSynchronizedRootGroup), currently an empty implementation to resolve error

Related Issues:

- Add object version 70 to version map
- Add support for new folder group type
@Brett-Best

Copy link
Copy Markdown
Contributor

You may be interested in #942 :)

@sborovikov-belkacar

Copy link
Copy Markdown

I’ve checked this fix locally on my Mac within Fastlane in a project with the new Xcode folders format. It's working!

@igor-makarov

Copy link
Copy Markdown
Contributor

@travis-mark I've looked at this PR, and while it fixes the crash, the underlying problem will not go away.

Since the FS-synchronized group is a new type with its own properties and child entities, Xcodeproj won't know how to output it. Which will cause the resulting project file to lose data.

I strongly recommend looking at #942 and perhaps helping out on it.

@amorde

amorde commented Oct 27, 2024

Copy link
Copy Markdown
Member

I've merged #985 which is a more complete implementation. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants