Adds method to remove file references from target - Issue 523 - #801
Open
MSandel wants to merge 2 commits into
Open
Adds method to remove file references from target - Issue 523#801MSandel wants to merge 2 commits into
MSandel wants to merge 2 commits into
Conversation
Here's an example of your CHANGELOG entry: * Adds method to remove file references from target - Issue 523
[MSandel](https://github.com/MSandel)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Contributor
|
Hi there, thanks for the PR! Can you add some tests for this new functionality? |
Contributor
|
Can you please add a test? Thanks! |
dnkoutso
reviewed
Jul 23, 2021
| # from the target. | ||
| # | ||
| def remove_file_references(file_references) | ||
| file_references.map do |file| |
Contributor
There was a problem hiding this comment.
why map and not. each? the method doc above does not denote a return type.
Contributor
|
ping @MSandel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #523