Skip to content

Fix crash when saving project. #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alonsir wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Fix crash when saving project. #1027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/xcodeproj/project/object/file_system_synchronized_exception_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,12 @@ class PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet < AbstractO
attribute :platform_filters_by_relative_path, Hash

def display_name
"Exceptions for \"#{GroupableHelper.parent(self).display_name}\" folder in \"#{build_phase.name}\" build phase"
build_phase_identifier = if build_phase.respond_to?(:name) && build_phase.name
build_phase.name
else
build_phase.uuid
end
"Exceptions for \"#{GroupableHelper.parent(self).display_name}\" folder in \"#{build_phase_identifier}\" build phase"

@sroyaura sroyaura Oct 20, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line can be removed? Currently it ends up in the pbxproj.

@alonsir alonsir Oct 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remove it entirely, this function has to return some string.
This eventually goes into the comment in the pbxproj file that describes the exception set.

end
end
end
Expand Down