Fix bad copy paste in cib_perform_op()#4038
Conversation
When calling crm_xml_add() use client instead of user Signed-off-by: Alexandra Diupina <dyupina99999@gmail.com>
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pacemaker/job/pacemaker-pipeline/job/PR-4038/1/input |
nrwahl2
left a comment
There was a problem hiding this comment.
Thanks! The fix looks good. Can you use the first part of the commit message from 86be2e4?
Fix: libcib: Fix setting origin attributes in CIB updates
This fixes a regression introduced by 53d4d34. The update-client
attribute was being set to the user instead of the update client.
This affects the outputs of the following public API functions and CLI
tools (via the cluster-status message with pcmk_section_times set):
* pcmk_simulate()
* pcmk_status()
* crm_mon
* crm_simulate
|
Hello! Ok, I'll resend it now UPD: #4040 |
|
Some people do close a PR and open a new one whenever they change something to keep the previous branch and commits and everything matching with previous comments. |
|
@wenningerk Hello! Thank you very much, I didn't know that amend and force push would also update the pull request. Now I won't have to recreate PRs anymore |
When calling crm_xml_add() use client instead of user