Skip to content

Fix bad copy paste in cib_perform_op()#4038

Closed
dyupina wants to merge 1 commit intoClusterLabs:3.0from
dyupina:3.0_fix_bad_copy_paste_in_cib_perform_op
Closed

Fix bad copy paste in cib_perform_op()#4038
dyupina wants to merge 1 commit intoClusterLabs:3.0from
dyupina:3.0_fix_bad_copy_paste_in_cib_perform_op

Conversation

@dyupina
Copy link

@dyupina dyupina commented Jan 28, 2026

When calling crm_xml_add() use client instead of user

When calling crm_xml_add() use client instead of user

Signed-off-by: Alexandra Diupina <dyupina99999@gmail.com>
@knet-jenkins
Copy link

knet-jenkins bot commented Jan 28, 2026

Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pacemaker/job/pacemaker-pipeline/job/PR-4038/1/input

@clumens clumens added the branch: 3.0 PRs for the 3.0 branch label Jan 28, 2026
Copy link
Contributor

@nrwahl2 nrwahl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The fix looks good. Can you use the first part of the commit message from 86be2e4?

Fix: libcib: Fix setting origin attributes in CIB updates

This fixes a regression introduced by 53d4d34. The update-client
attribute was being set to the user instead of the update client.

This affects the outputs of the following public API functions and CLI
tools (via the cluster-status message with pcmk_section_times set):
* pcmk_simulate()
* pcmk_status()
* crm_mon
* crm_simulate

@dyupina
Copy link
Author

dyupina commented Jan 29, 2026

Hello! Ok, I'll resend it now

UPD: #4040

@dyupina dyupina closed this Jan 29, 2026
@dyupina dyupina deleted the 3.0_fix_bad_copy_paste_in_cib_perform_op branch January 29, 2026 10:13
@wenningerk
Copy link
Contributor

Some people do close a PR and open a new one whenever they change something to keep the previous branch and commits and everything matching with previous comments.
Just wanted to make sure you know that you can just push (amend your previous commit and push with +HEAD) to your old branch as well and github will jump on that change.

@dyupina
Copy link
Author

dyupina commented Jan 29, 2026

@wenningerk Hello! Thank you very much, I didn't know that amend and force push would also update the pull request. Now I won't have to recreate PRs anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: 3.0 PRs for the 3.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants