Fix Windows CI uint128 backend selection#375
Merged
Merged
Conversation
Remove illegal std trait specializations from uint128_t, gate the fallback translation unit behind CHIAVDF_USE_UINT128_T_FALLBACK, and drive include.h from that single definition on Windows builds. Co-authored-by: Cursor <cursoragent@cursor.com>
Keeps include.h consistent with GCD/VDF headers that expect a uint128 type when CHIAVDF_USE_UINT128_T_FALLBACK is enabled. Co-authored-by: Cursor <cursoragent@cursor.com>
haorldbchi
previously approved these changes
Jun 16, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
haorldbchi
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespace stdtrait specializations from vendoreduint128_tthat break builds on MSVC STL 14.51 (windows-latest).CHIAVDF_USE_UINT128_T_FALLBACK, set by CMake and consumed byinclude.h.uint128_t.cppon clang-cl CI when nativeunsigned __int128is available, and defineuint128alias in the fallback path.Test plan
CI (windows-latest, optimized=1)passes in VDF client & HW CIMade with Cursor