This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Changes to support SQLServer over MS ODBC driver#47
Closed
adunstan wants to merge 6 commits intoCartoDB:masterfrom
Closed
Changes to support SQLServer over MS ODBC driver#47adunstan wants to merge 6 commits intoCartoDB:masterfrom
adunstan wants to merge 6 commits intoCartoDB:masterfrom
Conversation
added 6 commits
November 30, 2016 17:10
If we get 0 for the length of a a varchar field make it text. Also allow varbinary, which we treat as varbit(n) if we get a positive length and bytea if not.
|
First of all thank you very much for sharing your changes to make it works with that driver. Also, I've seen some fixes in our code that could be interesting to apply. As I said to another contributor, please read this document and we need a signed CLA to include the code. Thank you! |
|
I am closing this in favour of #74, which is just these changes rebased to our master, which has had a lot of changes since this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a set of changes I made to enable the FDW to be used over the MS ODBC Driver v 13 for Linux.