[codex] Fix update failure log filters#2321
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChart clicks now map buckets to one-or-more log ChangesMulti-action stats filtering
Playwright test frontend infrastructure
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
0dc872e to
9f42633
Compare
hadessunxy-code
left a comment
There was a problem hiding this comment.
Reviewed the chart-to-logs filter path. The repeated action query params should round-trip correctly through Vue Router, and the log table now restores all matching filters instead of only the first failure action.
No blocker from me. The one follow-up I would consider is moving the update failure action list into a shared stats/logs helper, because it now needs to stay in sync with both the aggregated fail statistic and statsActions.ts. That would reduce the chance of a future failure action being counted in the chart but omitted from the log drill-down.
9f42633 to
a03301d
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/playwright-frontend-preview.ts`:
- Around line 3-4: The code currently defaults SUPABASE_URL to '' which produces
a bad apiDomain; update the logic around process.env.SUPABASE_URL and the
derived apiDomain so it fails fast when SUPABASE_URL is missing (throw an error
or call process.exit with a clear message) and normalize the URL before building
apiDomain: read process.env.SUPABASE_URL into supabaseUrl, validate it is
non-empty, strip any trailing slash and any protocol only when composing
apiDomain (use supabaseUrl.replace(/^https?:\/\//, '').replace(/\/$/, '') to
produce the host) and then set apiDomain = `${normalizedHost}/functions/v1`;
ensure the error message references SUPABASE_URL and the variables supabaseUrl
and apiDomain for clarity.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c0bc93c2-c80b-43c3-b102-14e6ac7da011
📒 Files selected for processing (4)
.github/workflows/tests.ymlscripts/playwright-frontend-preview.tssrc/components/dashboard/UpdateStatsChart.vuesrc/components/tables/LogTable.vue
a03301d to
fc27ef5
Compare
|



Summary (AI generated)
failbucket opens logs filtered by every*_failevent it aggregates.actionquery parameter support on the logs page so multiple filters are restored from URL state.vite preview, avoiding the Vite dependency optimizer hang seen in the duplicate push run.Motivation (AI generated)
Clicking
failin Updates statistics previously opened logs for only one failure action, so most users saw no matching events even though the chart counted failures from several event types. The CI frontend change keeps Playwright checks stable while preserving full browser coverage.Business Impact (AI generated)
This makes update failure investigation reliable from the dashboard, reducing support/debug time and helping users identify real OTA update failure causes faster. The CI hardening also avoids wasting review time on unrelated Playwright startup flakes.
Test Plan (AI generated)
bun lintbun typecheckbun run buildbun build scripts/playwright-frontend-preview.ts --outdir /tmp/capgo-playwright-preview-check.github/workflows/tests.ymlwith the repo YAML parserGenerated with AI
Summary by CodeRabbit
New Features
Chores