typing with args of global functions (except multiplication, element)#910
Open
typing with args of global functions (except multiplication, element)#910
Conversation
IgnaceBleukx
requested changes
Apr 7, 2026
Collaborator
IgnaceBleukx
left a comment
IgnaceBleukx
left a comment
There was a problem hiding this comment.
Yes, the xxx_listlike helper functions make a lot of sense!
I suppose we'll update the .value() funcs of Operator and GlobalConstraints in future PRs in a similar style?
One blocking comment on the addition in __pow__, otherwise looks good to go
Collaborator
Author
Yes, for future PRs... |
Merged
IgnaceBleukx
added a commit
that referenced
this pull request
May 6, 2026
* typing of min/max This is a small, more specialised subset of #910 mypy_globfunc Here we for the first time filter out the np.integers in a global, so we don't have to account for them later... With that, we don't need the circular imported Expression in the typed utils (because with int|Expression, if not int, then implicitly Expression) * min/max: stricter typed constructor, simpler helper * doc updates * review comments, new npint2int --------- Co-authored-by: Ignace Bleukx <ignace.bleukx@kuleuven.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skipped multiplication because of a float test that needs to be rewritten first
element because I expect some hard-to-type multidim related things that might be revised in #444 anyway