feat: animate StatsModal bars and stat numbers on modal open#42
Open
albert239825 wants to merge 1 commit into
Open
feat: animate StatsModal bars and stat numbers on modal open#42albert239825 wants to merge 1 commit into
albert239825 wants to merge 1 commit into
Conversation
- Add @Keyframes growBar animation for win distribution bars - Add staggered animation-delay via CSS custom properties - Add count-up animation for stat numbers using useState/useEffect - Bars grow from 0% to final width with 0.1s stagger per row - Stat numbers animate from 0 to target value over 500ms Co-Authored-By: Albert Chen <albert23982@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Testing ResultsTested the animated StatsModal locally with Animation Tests (all passed)
Bar animation proof (CSS inspection):
Count-up proof (MutationObserver, 52 captures):
Reset proof:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the StatsModal win distribution from static bars to animated bars that grow on modal open, plus a count-up animation for the stat numbers.
Bar animation: Added
@keyframes growBarthat animateswidthfrom0%→var(--bar-width). EachProgressrow receives a staggeredanimation-delayvia CSS custom property (--stagger-delay: ${index * 0.1}s), so bars cascade in sequentially.Stat count-up:
StatItemnow acceptsisOpenand usesuseState/useEffectto animate the displayed number from 0 → target over ~500ms (20 steps viasetInterval). Resets to 0 when the modal closes so it replays on reopen.Link to Devin session: https://app.devin.ai/sessions/9240699c31bb40fba0e3ff0696399f32
Requested by: @albert239825
Devin Review