feature: add explicit light mode theme (default)#34
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
feature: add explicit light mode theme (default)#34devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: shahmir.masood <shahmir.masood@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes light mode an explicit, well-defined theme and the default on first load. Previously "off" dark mode just removed
data-theme, relying on the:rootfallback; now light mode is a named theme set viadata-theme="light", mirroring howdarkworks.Key changes:
App.module.scss: added an explicit[data-theme='light']variable block (alongside the existing:rootdefaults and[data-theme='dark']), and changed the hardcodedbody { color: #fff }tovar(--color-text-primary)so text is readable in light mode.App.jsx: the theme effect now sets the attribute in both directions instead of removing it:App.jsx: default storedthemechanged from'dark'to'light', so first-time visitors get light mode. The existing toggle inSettingModal("Dark Mode") already persists'light'/'dark'to localStorage viahandleDarkMode, so the choice continues to survive reloads.Screenshots
Light mode (new default):
Dark mode (via Settings → Dark Mode, persists across reloads):
Testing
npm run check(prettier) passes.data-themeand persists (localStorage.theme="dark",body[data-theme="dark"]) across reload.App.test.jsx) fails onmainas well (unrelated —useAlertis undefined without its provider in the test). Not introduced by this PR.Link to Devin session: https://app.devin.ai/sessions/edc13b821f804c1ebec949e766235288
Requested by: @shahmir-masood
Devin Review