fix: [Vulns #2,6,8] upgrade tap 11.x → 18.x to resolve 3 critical transitive dependency CVEs#23
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…nsitive dependency CVEs Co-Authored-By: Jake Luo <jake.luo@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
tapfrom^11.1.3to^18.0.0to resolve 3 critical transitive dependency CVEs:All three packages were transitive dependencies pulled in through
tap@11.x. After upgrading totap@18.x:form-data@2.3.3— no longer in the dependency treebabel-traverse@6.26.0— no longer in the dependency treesha.js@2.4.11— no longer pulled throughtap(remaining instances come frombrowserifyandtypeorm)Files changed:
package.json,package-lock.jsonReview & Testing Checklist for Human
npm ls tapshowstap@18.xinstalled correctlynpm ls form-datano longer showsform-data@2.3.3as a transitive dep of tapnpm ls babel-traversereturns empty (no longer in tree)Notes
tapis listed underdependenciesrather thandevDependenciesin this repo. The upgrade is scoped only to thetapversion — no application code changes were needed.sha.js@2.4.11still appears viabrowserifyandtypeorm— those are separate dependency paths unrelated to this fix.Link to Devin session: https://app.devin.ai/sessions/d44b2a02e84f46e7874d5ac33659836c
Requested by: @jakejluo
Devin Review