chore(js-ts): Convert Swaps AssetSwapButton, TokenSelectButton to TypeScript#986
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
chore(js-ts): Convert Swaps AssetSwapButton, TokenSelectButton to TypeScript#986devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…eScript feature: migrate two presentational Swaps UI components from JS to TS. Replaces PropTypes with TypeScript interfaces; renames the TokenSelectButton test and snapshot to .tsx. No behavioral changes; snapshots identical. Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
Bot
added
needs-dev-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of Workstream 2 (Base & UI component JS→TS migration). Converts two presentational Swaps UI components from JS to TS. Type-only changes; snapshots identical.
app/components/UI/Swaps/components/AssetSwapButton.js→.tsxapp/components/UI/Swaps/components/TokenSelectButton.js→.tsxTokenSelectButton.test.js→.test.tsx(and its snapshot file renamed to match)Worth knowing (rest is mechanical PropTypes→interface):
useModalHandleris already typed (as consttuple), so the destructure types flow through. The consumedAssetActionButton/InfoModalare still untyped JS.SelectorButton'sonPressis required-typed(e: GestureResponderEvent) => void, while this component'sonPressis optional, so it's passed asonPress as () => voidto drop the| undefined(preserves passingundefinedexactly).TokenSelectButton.test.js.snap→TokenSelectButton.test.tsx.snap; its contents are byte-identical (verified), and the 5 snapshots pass as matches (not rewrites).Validation (local)
yarn lint:tsc: passes, 0 errors (full project).eslinton all three files: clean (noany).yarn jest(TokenSelectButton): 5 snapshots pass, identical.CI note
The install-gated CI jobs on this fork fail before reaching any TS/test step due to a preexisting broken dependency (
react-native-tcppins a GitHub commit that now 404s onyarn install);check-diff/CLABot/label checks also fail on all fork PRs for preexisting infra/governance reasons. None are caused by this diff, which contains file renames + type annotations and no lockfile change.Link to Devin session: https://app.devin.ai/sessions/a0f7f796d1fb45e88b2feabe5829a4ac
Requested by: @WesternConcrete
Devin Review