Skip to content

chore(js-ts): Convert Confetti to TypeScript#981

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
chore/js-ts-confetti-307
Open

chore(js-ts): Convert Confetti to TypeScript#981
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
chore/js-ts-confetti-307

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jun 23, 2026

Copy link
Copy Markdown

Summary

Part of Workstream 2 (Base & UI component JS→TS migration). Converts the Confetti UI component from JS to TS. Type-only changes — snapshot identical.

  • app/components/UI/Confetti/index.js.tsx
  • app/declarations/index.d.ts: adds declare module 'react-native-confetti'; (the lib ships no types; per project policy we declare the module rather than installing @types).

Worth knowing (rest is mechanical):

  • Props are typed Partial<ExplosionProps> (imported from react-native-confetti-cannon, which ships its own types). The only caller renders <Confetti /> with no props; the explicit count/origin/fadeOut on ConfettiCannon remain, with {...props} spread after.

  • The mutable ref holder is typed to expose the method used on Android:

    let confettiView: { startConfetti: () => void } | false = false;

    No any introduced.

Validation (local)

  • yarn lint:tsc: passes, 0 errors.
  • eslint on the file: passes (0 errors; one non-blocking import/no-named-as-default-member warning that originates from ESLint failing to parse the third-party react-native-confetti-cannon JS source — unrelated to this diff).
  • yarn jest (Confetti): 1 suite / 1 test pass, snapshot identical.

CI note

The install-gated CI jobs on this fork fail before reaching any TS/test step due to a preexisting broken dependency (react-native-tcp pins a GitHub commit that now 404s on yarn install); check-diff/CLABot/label checks also fail on all fork PRs for preexisting infra/governance reasons (ruby/setup-ruby detects the macOS runner as self-hosted). None are caused by this diff, which contains only a file rename, a module declaration, and type annotations — no lockfile change.

Link to Devin session: https://app.devin.ai/sessions/a0f7f796d1fb45e88b2feabe5829a4ac
Requested by: @WesternConcrete


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Open in Devin Review (Staging)

feature: migrate the Confetti UI component from JS to TS. Types props as
Partial<ExplosionProps> from react-native-confetti-cannon and declares the
untyped react-native-confetti module in app/declarations/index.d.ts. No
behavioral changes; snapshot identical.

Co-Authored-By: Wes Convery <2wconvery@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants