chore(js-ts): Type signatureRequest reducer and remove any from RootState#978
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
chore(js-ts): Type signatureRequest reducer and remove any from RootState#978devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Export the SignatureRequestState interface from the signatureRequest reducer and use it in RootState instead of any. Fix cascading type errors surfaced in the security-alerts selector and test fixtures previously hidden by any. Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of Workstream 4 (type Redux reducers, eliminate
anyfromRootState). ThesignatureRequestreducer and action were already TypeScript, so this only exports the state interface and wires it intoRootState:Cascade (errors previously hidden by
any)The reducer state stores the BlockaidBanner
SecurityAlertResponse(enumreason/result_type,features: (string | Record)[]), which is not assignable to the transaction-controllerSecurityAlertResponse(features: string[]) thatselectSignatureSecurityAlertResponsedeclares and its consumers rely on (it's??-merged withtransactionMetadata.securityAlertResponse). These two types genuinely diverge, so the selector now casts at that boundary to preserve its existing public contract:Test fixtures that put a
securityAlertResponseinto the now-typedsignatureRequestslot are reconciled by typing the sharedsecurityAlertResponsehelper inconfirm-data-helpers.tsas the BlockaidBanner shape (fixessecurity-alerts,confirm-component,useSignatureMetrics,useSecurityAlertResponse,signature-blockaid-bannertests transitively).TypedSign/index.test.tsx's inline fixture andinitial-root-state.ts(signatureRequest: {}) are adjusted directly.Behavior is unchanged — types only.
Validation
yarn tsc— 0 errorsyarn lint— 0 errors (warnings only)yarn jeston the affected selector/hook/component tests — 33 tests passLink to Devin session: https://app.devin.ai/sessions/150060d9c6a14a1b9ee04e5a407b3f8b
Requested by: @WesternConcrete
Devin Review