Skip to content

chore(js-ts): Convert SettingsNotification, AssetList to TypeScript#976

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
chore/js-ts-settingsnotif-assetlist-861
Open

chore(js-ts): Convert SettingsNotification, AssetList to TypeScript#976
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
chore/js-ts-settingsnotif-assetlist-861

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jun 23, 2026

Copy link
Copy Markdown

Summary

Part of Workstream 2 (Base & UI component JS→TS migration). Converts two presentational UI components from JS to TS. Type-only changes — snapshots identical.

  • app/components/UI/SettingsNotification/index.js.tsx
  • app/components/UI/AssetList/index.js.tsx

Worth knowing (rest is mechanical PropTypes→interface):

  • SettingsNotification: the old defaultProps (style = {}, isWarning = false) are moved to destructured default params. An unused isHighlighted default (no matching prop / usage) is dropped. Object.assign({}, styles.menuItemWarning, style) casts style as ViewStyle since StyleProp<ViewStyle> isn't a plain object.
  • AssetList: handleSelectAsset is typed ((asset: Asset) => void) | null because its .test.tsx passes handleSelectAsset={null}; call sites use optional chaining handleSelectAsset?.(...) (only reachable on press, never with the null test case, so snapshot is unchanged). searchQuery?.length guards the optional prop. logo={iconUrl as string} at the AssetIcon boundary preserves the previous runtime (passing undefined through — AssetIcon returns null for falsy logo).

Validation (local)

  • yarn lint:tsc: passes, 0 errors.
  • eslint on both files: clean (no any).
  • yarn jest (SettingsNotification, AssetList): 2 suites pass, 3 snapshots identical.

CI note

The install-gated CI jobs on this fork fail before reaching any TS/test step due to a preexisting broken dependency (react-native-tcp pins a GitHub commit that now 404s on yarn install); check-diff/CLABot/label checks also fail on all fork PRs for preexisting infra/governance reasons (ruby/setup-ruby detects the macOS runner as self-hosted). None are caused by this diff, which contains only file renames + type annotations and no lockfile change.

Link to Devin session: https://app.devin.ai/sessions/a0f7f796d1fb45e88b2feabe5829a4ac
Requested by: @WesternConcrete


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Open in Devin Review (Staging)

feature: migrate two presentational UI components from JS to TS. Replaces
PropTypes (and defaultProps via default params) with TypeScript interfaces.
No behavioral changes; snapshots identical.

Co-Authored-By: Wes Convery <2wconvery@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants