Skip to content

chore(js-ts): Convert TabCountIcon, NetworkMainAssetLogo to TypeScript#975

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
chore/js-ts-tabcounticon-networkmainassetlogo-479
Open

chore(js-ts): Convert TabCountIcon, NetworkMainAssetLogo to TypeScript#975
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
chore/js-ts-tabcounticon-networkmainassetlogo-479

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jun 23, 2026

Copy link
Copy Markdown

Summary

Part of Workstream 2 (Base & UI component JS→TS migration). Converts two Redux-connected UI components from JS to TS. connect() HOCs are kept (not converted to hooks); type-only changes — snapshots identical.

  • app/components/UI/Tabs/TabCountIcon/index.js.tsx
  • app/components/UI/NetworkMainAssetLogo/index.js.tsx

Worth knowing (rest is mechanical PropTypes→interface):

  • Both type mapStateToProps = (state: RootState) => ... (RootState from app/reducers), following the existing convention in AccountFromToInfoCard.tsx.
  • TabCountIcon is a class component using ThemeContext; keeps static contextType = ThemeContext and reads colors via (this.context as unknown as Theme).colors || mockTheme.colors — the established pattern in already-converted class components (e.g. Views/PickComponent).
  • NetworkMainAssetLogo passes its style into TokenIcon, which is still JS and infers style: object from its PropTypes. The prop is typed idiomatically as StyleProp<ViewStyle> and cast to ViewStyle only at the TokenIcon (untyped-JS) call boundary; the cast disappears once TokenIcon is itself converted.

Validation (local)

  • yarn lint:tsc: passes, 0 errors.
  • eslint on both files: clean (no any).
  • yarn jest (TabCountIcon, NetworkMainAssetLogo): 2 suites pass, 2 snapshots identical.

CI note

The install-gated CI jobs on this fork fail before reaching any TS/test step due to a preexisting broken dependency (react-native-tcp pins a GitHub commit that now 404s on yarn install); check-diff/CLABot/label checks also fail on all fork PRs for preexisting infra/governance reasons (ruby/setup-ruby detects the macOS runner as self-hosted). None are caused by this diff, which contains only file renames + type annotations and no lockfile change.

Link to Devin session: https://app.devin.ai/sessions/a0f7f796d1fb45e88b2feabe5829a4ac
Requested by: @WesternConcrete


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Open in Devin Review (Staging)

feature: migrate two Redux-connected UI components from JS to TS. Replaces
PropTypes with TypeScript interfaces and types mapStateToProps(state: RootState).
Keeps connect() HOCs. No behavioral changes; snapshots identical.

Co-Authored-By: Wes Convery <2wconvery@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants