Skip to content

chore(js-ts): Convert DetailsModal to TypeScript#971

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
chore/js-ts-detailsmodal-298
Open

chore(js-ts): Convert DetailsModal to TypeScript#971
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
chore/js-ts-detailsmodal-298

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jun 23, 2026

Copy link
Copy Markdown

Summary

Part of Workstream 2 (Base & UI component JS→TS migration). Converts the DetailsModal compound presentational component (app/components/Base/DetailsModal.js.tsx). Type-only change — rendered output identical.

Worth knowing (rest is mechanical PropTypes→interface):

  • Sub-components are typed by the element they render: DetailsModalHeader/Body use ViewProps, CloseIcon uses TouchableOpacityProps, Title/SectionTitle use React.ComponentProps<typeof Text>. Section/Column extend ViewProps with borderBottom?: boolean / end?: boolean.

  • The compound statics (DetailsModal.Header = ...) are now attached via Object.assign so the default export carries typed statics:

    export default Object.assign(DetailsModal, {
      Header: DetailsModalHeader,
      Title: DetailsModalTitle,
      // ...Body, CloseIcon, Section, SectionTitle, Column
    });

    This is behavior-identical to the previous DetailsModal.Header = DetailsModalHeader mutations.

Validation (local)

  • yarn lint:tsc: passes, 0 errors.
  • eslint on the file: clean (no any).
  • yarn jest consumer suites (MultichainTransactionDetailsModal, MultichainTransactionListItem): 16 tests pass.

CI note

The install-gated CI jobs on this fork fail before reaching any TS/test step due to a preexisting broken dependency (react-native-tcp pins a GitHub commit that now 404s on yarn install); check-diff/CLABot/label checks also fail on all fork PRs for preexisting infra/governance reasons (e.g. ruby/setup-ruby detects the macOS runner as self-hosted). None of these are caused by this diff, which contains a single file rename + type annotations and no lockfile change.

Link to Devin session: https://app.devin.ai/sessions/a0f7f796d1fb45e88b2feabe5829a4ac
Requested by: @WesternConcrete


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Open in Devin Review (Staging)

feature: migrate the DetailsModal compound presentational component from JS to
TS. Replaces PropTypes with TypeScript interfaces and types each sub-component
(Header/Title/CloseIcon/Body/Section/SectionTitle/Column). No behavioral
changes; rendered output identical.

Co-Authored-By: Wes Convery <2wconvery@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants