chore(js-ts): Convert StatusText, TabBar, WebviewProgressBar to TypeScript#970
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
chore(js-ts): Convert StatusText, TabBar, WebviewProgressBar to TypeScript#970devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…cript feature: migrate three simple presentational Base/UI components from JS to TS. Replaces PropTypes with TypeScript interfaces; adds a module declaration for react-native-progress/Bar. No behavioral changes; snapshots identical. Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of Workstream 2 (Base & UI component JS→TS migration). Converts three simple presentational components from JS to TS. Type-only changes — no behavior changes, snapshots identical.
app/components/Base/StatusText.js→.tsxapp/components/Base/TabBar.js→.tsxapp/components/UI/WebviewProgressBar/index.js→.tsxDetails worth knowing (rest is mechanical):
StatusText: dropped
prop-types; props typed viainterface StatusTextProps extends React.ComponentProps<typeof Text> { status: string; context?: string }. Thecontextdefault moved fromdefaultPropsto a default param (context = 'transaction') — render output unchanged. Sub-component exports (ConfirmedText/PendingText/FailedText) typed asReact.ComponentProps<typeof Text>.TabBar: thin passthrough wrapper; props typed as
React.ComponentProps<typeof DefaultTabBar>(the module is already declared asReact.FC<any>inapp/declarations/index.d.ts).WebviewProgressBar: class
PureComponent<WebviewProgressBarProps, WebviewProgressBarState>;progress?: number.react-native-progress/Barhas no published types, so a module declaration was added toapp/declarations/index.d.ts(per migration guidelines — not installing a new@typespackage):Validation (local)
yarn lint:tsc(tsc --noEmit): passes, 0 errors.eslinton changed files: clean (noany).yarn jest: WebviewProgressBar snapshot test passes (identical).--findRelatedTestsfor TabBar/WebviewProgressBar: 45 tests / 25 snapshots pass.CI note
The install-gated CI jobs on this fork fail before reaching any TS/test step due to a preexisting broken dependency (
react-native-tcppins a GitHub commit that now 404s onyarn install). This affects all PRs andmain, not this diff. The 3Test suite failed to runresults locally (Nav/Main,Nav/App,Views/Root) are due to a missing generated assetapp/lib/ppom/ppom.html.js(gitignored build artifact), also unrelated to this change.Link to Devin session: https://app.devin.ai/sessions/a0f7f796d1fb45e88b2feabe5829a4ac
Requested by: @WesternConcrete
Devin Review