Migrate Angular 9 to React 18 + TypeScript + Vite#319
Open
devanshi-gpta wants to merge 1 commit into
Open
Conversation
- Replace Angular 9 with React 18 + TypeScript + Vite - Migrate all Angular services to React hooks/context (useHackerNewsAPI, SettingsContext) - Convert all components to React functional components with hooks - Set up React Router v6 with lazy-loaded routes for ItemDetails and User - Migrate SCSS theme engine with day/night/AMOLED black themes - Add vite-plugin-pwa for PWA support with Workbox runtime caching - Add Google Analytics page tracking via usePageTracking hook - Add Vitest + React Testing Library tests (15 tests across 4 suites) - Move static assets to public/ for Vite - Update README for new React stack - Remove all Angular dependencies, configs, and source files Co-Authored-By: Devanshi Gupta <devanshi.gupta@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
E2E Test Results — Angular 9 → React 18 MigrationRan the migrated React app locally ( Test Results (5/5 passed)
Show/Ask feed routing
Known Issue: User Profile APIThe upstream HN API at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Full replacement of the Angular 9 application with a React 18 + TypeScript + Vite stack, preserving all existing functionality.
Architecture:
useFeed,useItem,useUser) and context (SettingsProvider)@angular/router→react-router-domv6 withcreateBrowserRouter;ItemDetailsandUserpages areReact.lazy()loaded@angular/service-worker→vite-plugin-pwawith Workbox runtime caching for the HN APIunfetch→ plainfetch+async/awaitCommentPipe) → utility functionformatCommentCount()Key mapping:
Preserved:
localStoragepersistence for settings (theme, font size, spacing, open-in-new-tab)prefers-color-scheme: darkmedia query listenerTesting: 15 tests across 4 suites (Feed, ItemDetails, User, SettingsContext) using Vitest + React Testing Library.
Removed: All Angular deps (
@angular/*,rxjs,zone.js,unfetch,karma,jasmine,protractor,codelyzer,tslint), Angular config files, ande2e/directory.Link to Devin session: https://app.devin.ai/sessions/3db76cb4948b4000a384a2b988e7747e
Requested by: @devanshi-gpta
Devin Review