forked from housseindjirdeh/angular2-hn
-
Notifications
You must be signed in to change notification settings - Fork 12
Phase 2: Services, Settings Context & Shared Utilities #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vibhaseshadri-cognition
wants to merge
3
commits into
master
Choose a base branch
from
devin-06.09.2026-vibha/react-migration-phase2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
e75d33a
feat: Phase 1 - React 18 + Vite + TypeScript foundation
devin-ai-integration[bot] d1e1400
feat: Phase 2 - Services, Settings Context, and shared utilities
devin-ai-integration[bot] ee71d5d
fix: update loading spinner CSS selector for React (#root:empty)
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,3 +44,6 @@ testem.log | |
| # System Files | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Vite | ||
| *.local | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Angular 2 HN</title> | ||
|
|
||
| <meta name="description" content="A Hacker News client built with Angular CLI, RxJS and Webpack"/> | ||
|
|
||
| <meta name="twitter:card" content="summary"> | ||
| <meta name="twitter:site" content="@hdjirdeh"> | ||
| <meta name="twitter:title" content="Angular 2 HN"> | ||
| <meta name="twitter:description" content="A Hacker News client built with Angular CLI, RxJS and Webpack"> | ||
| <meta name="twitter:creator" content="@hdjirdeh"> | ||
| <meta name="twitter:image" content="/assets/images/logo-loading.png"> | ||
|
|
||
| <meta property="og:title" content="Angular 2 HN"/> | ||
| <meta property="og:type" content="website"/> | ||
| <meta property="og:url" content="https://angular2-hn.firebaseapp.com/"/> | ||
| <meta property="og:image" content="/assets/images/logo-loading.png"/> | ||
| <meta property="og:description" content="A Hacker News client built with Angular CLI, RxJS and Webpack"/> | ||
| <meta property="og:site_name" content="Angular 2 HN"/> | ||
| <meta property="fb:admins" content="10202985971279760"/> | ||
|
|
||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
|
|
||
| <meta name="theme-color" content="#b92b27"> | ||
|
|
||
| <meta name="msapplication-TileColor" content="#b92b27"> | ||
| <meta name="msapplication-TileImage" content="/assets/icons/mstile-150x150.png"> | ||
| <meta name="msapplication-config" content="/assets/icons/browserconfig.xml"> | ||
|
|
||
| <meta name="apple-mobile-web-app-capable" content="yes"> | ||
| <meta name="apple-mobile-web-app-status-bar-style" content="black"> | ||
|
|
||
| <link rel="manifest" href="/manifest.json"> | ||
| <link rel="mask-icon" href="/assets/icons/safari-pinned-tab.svg" color="#b92b27"> | ||
|
|
||
| <link rel="icon" type="image/x-icon" href="/favicon.ico"> | ||
| <link rel="icon" type="image/png" href="/assets/icons/favicon-32x32.png" sizes="32x32"> | ||
| <link rel="icon" type="image/png" href="/assets/icons/favicon-16x16.png" sizes="16x16"> | ||
|
|
||
| <link rel="apple-touch-icon" sizes="180x180" href="/assets/icons/apple-touch-icon.png"> | ||
| <link rel="apple-touch-icon" sizes="120x120" href="/assets/icons/apple-touch-icon-120x120.png"> | ||
| <link rel="apple-touch-icon" sizes="152x152" href="/assets/icons/apple-touch-icon-152x152.png"> | ||
| <link rel="apple-touch-icon" sizes="180x180" href="/assets/icons/apple-touch-icon-180x180.png"> | ||
|
|
||
| <style> | ||
| #skip a { position:absolute; left:-10000px; top:auto; width:1px; height:1px; overflow:hidden; } | ||
| #skip a:focus { position:static; width:auto; height:auto; } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <div id="skip"><a href="#content">skip to navigation</a></div> | ||
| <div id="root"></div> | ||
|
|
||
| <div class="app-loader" id="content"> | ||
| <img class="logo" src="/assets/images/logo.svg" alt="Logo"> | ||
| <noscript> | ||
| <h4 style="font-family: 'HelveticaNeue-Light', 'Helvetica Neue Light', 'Helvetica Neue', Helvetica;"> | ||
| Sorry, JavaScript needs to be enabled in order to run this application. | ||
| </h4> | ||
| </noscript> | ||
| </div> | ||
|
|
||
| <script> | ||
| (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ | ||
| (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o), | ||
| m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m) | ||
| })(window,document,'script','https://www.google-analytics.com/analytics.js','ga'); | ||
|
|
||
| ga('create', 'UA-66348622-3', 'auto'); | ||
| </script> | ||
| <script type="module" src="/src/main.tsx"></script> | ||
| </body> | ||
| </html> | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Loading spinner CSS selector is broken after migration from to
The existing
src/styles.scss:37-40definesapp-root:empty + .app-loader { opacity: 1; z-index: 100; }which showed the loading spinner while Angular bootstrapped. The newindex.html:54uses<div id="root"></div>instead of<app-root></app-root>, so this CSS selector never matches. The.app-loaderdefault style (opacity: 0; z-index: -1atsrc/styles.scss:22-23,28) keeps the loader permanently hidden. This means: (1) no loading indicator displays while React initializes, and (2) the<noscript>message atindex.html:58-62is invisible in production builds where the bundled CSS is loaded via a<link>tag even without JS. Consider updating the CSS selector to#root:empty + .app-loaderor removing the.app-loaderdiv entirely if the loading state is no longer needed.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed in ee71d5d — updated the selector to
#root:empty + .app-loaderto match the React mount point.