Improve test coverage from 23% to 82%#10
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Created RestSharp.Net7 SDK-style project referencing original sources - Created RestSharp.Tests.Coverage test project with 677 passing tests - Added InternalsVisibleTo to expose internal OAuth classes for testing - Coverage: 82.23% line, 74.89% branch, 92.77% method Test files added: - RestRequestTests, RestClientTests, RestResponseTests - AuthenticatorTests (Basic, Simple, OAuth2, NTLM, OAuth1) - OAuthInternalTests (OAuthTools, WebPair*, OAuthWorkflow, etc.) - HttpSyncTests, HttpTests, HttpResponseTests, HttpCookieTests - XmlAttributeDeserializerTests, XmlSerializerEdgeTests - DotNetXmlTests, JsonSerializerTests - StringExtensionsTests, MiscExtensionsTests, ReflectionExtensionsTests - ValidationTests, ParameterTests, FileParameterTests - FactoryAndEnumTests, AttributeAndContribTests - HttpUtilityTests, WebPairCollectionTests - RestClientAdditionalTests, RestClientExecuteTests - CoverageBoostTests Co-Authored-By: Bobby Nobakht <bobby.nobakht@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved test coverage for the RestSharp library from 23.07% baseline to 82.23% line coverage, exceeding the 80% threshold.
Changes
InternalsVisibleToto expose internal OAuth classes for testingCoverage Results
Test Files
Review & Testing Checklist for Human
dotnet testin RestSharp.Tests.Coverage to verify all 677 tests passdotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=cobertura /p:Include="[RestSharp]*"Notes
<Compile Include>wildcards rather than copying/modifying themInternalsVisibleToattribute to enable testing of internal OAuth infrastructure classeslocalhost:1to trigger connection errors, exercising the error-handling code paths without needing a live serverLink to Devin session: https://app.devin.ai/sessions/7ebfa491af43427696d9415e079e06c6
Requested by: @bnob-git
Devin Review