Skip to content

Viz gt exploration#16

Open
Libonet wants to merge 6 commits into
CIFASIS:mainfrom
Libonet:viz_gt_exploration
Open

Viz gt exploration#16
Libonet wants to merge 6 commits into
CIFASIS:mainfrom
Libonet:viz_gt_exploration

Conversation

@Libonet

@Libonet Libonet commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Instead of hardcoding the transforms between baselink and imu, we now read them from the urdf in the data section of the repo.

We also add a visualization of the data in 3d space with plotly

Comment thread scripts/gt_exploration.ipynb Outdated
"source": [
"## Definitions ##\n",
"MINS_OUTPUT_BASE_PATH = \\\n",
" '/home/libonati/Documents/dataset_rosariov2/mins/'\n",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove /home/libonati and add something like Path('~/Documents...').expanduser() or os.path.expanduser('~/Documents/...')

Or even replace it with an empty path DATASET_PATH, a markdown message telling the user to define this variable and an assertion that the variable is not empty.

Or even more, we do ask in the documentation for a "$ROSARIOV2" variable defined in the environment, so you could try and pull the value from this variable if DATASET_PATH is undefined.

"## Definitions ##\n",
"MINS_OUTPUT_BASE_PATH = \\\n",
" '/home/libonati/Documents/dataset_rosariov2/mins/'\n",
"DATASET_SESSIONS = [\n",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having all sessions but one commented out, maybe you can set it like:

DATASET_SESSION = [ ... ][0]

and allow the user to change that number to index other sessions.

Not a blocking issue, makes no significant difference.

Comment thread scripts/gt_exploration.ipynb Outdated
"print(*ground_truth_paths, sep='\\n')\n",
"\n",
"gt_data = pd.read_csv(\n",
" ground_truth_paths[0], sep=' ', header=None, names=MINS_OUTPUT_COLUMNS)\n",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have the same dataset index as above, if reading the "0-th" dataset then index the "0-th" ground truth path, and so on.

"metadata": {},
"outputs": [],
"source": [
"# HTML to show the plot on the rosariov2 page\n",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way to show this html embedded here without any additional library plugins, right?

Comment thread scripts/gt_exploration.ipynb Outdated
"# HTML to show the plot on the rosariov2 page\n",
"if not Path(\"gt_exploration_plot.html\").exists:\n",
" print(\"Creating HTML\")\n",
" fig.write_html(\"gt_exploration_plot.html\")"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the name of the trajectory as part of the output name.

"# Create 3D plot\n",
"fig = go.Figure(data=[go.Scatter3d(\n",
" x=gt_data['tx'], y=gt_data['ty'], z=gt_data['tz'],\n",
" mode='lines+markers',\n",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can show the markers as arrows pointing in the direction of the trajectory? Same as we do above with the segments we show in red?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants