Developing of Doppler velocity simulator#148
Closed
yuhi-n wants to merge 801 commits intoCFMIP:masterfrom
Closed
Conversation
The modified line was causing this error: ==19971== Conditional jump or move depends on uninitialised value(s) ==19971== at 0xA47583: __mod_cosp_MOD_cosp_simulator (cosp.F90:502) ... when cospOUT%isccp_meantb is not allocated. I noticed all surrounding accesses of members of cospOUT were guarded by association checks, so I added that check.
Update intel KGOs to v004.
Make rcfg_cloudsat a HEAP variable Merging because the the errors are the same as the differences between v003 and v004 KGOs of the intel compilers, fixed in PR CFMIP#100.
Fix a valgrind uninitialized conditional error in cosp
…er/actions/upload-artifact-4.4.0 Bump actions/upload-artifact from 4.3.3 to 4.4.0 Errors in intel compilers tests caused fixed in PR CFMIP#100.
…t (clw_scheme=2, ice_scheme=1, icede_param=4).
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.0 to 4.4.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.4.0...v4.4.1) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ter/actions/upload-artifact-4.4.1
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5.0.0...v6.0.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
|
@yuhi-n This is exciting. While we are getting specialists to review the code please resolve the conflicts with COSP, which was recently updated to include another simulator. |
|
@yuhi-n thanks for opening this PR. Is there any publication that documents this Doppler simulator? If so, please could you add a link in the description above? |
Author
|
@RobertPincus Thank you for your comment. I'm currently working to resolve these conflicts. @mo-abodas Thank you for your comment. I have our publication for documentation of this simulator with ground-based radar observation. The following link is a preprint, but recently it has been accepted. I will update this once the journal link is available. |
Contributor
|
Congratulation @yuhi-n looks like the manuscript is now published. |
Bumps [conda-incubator/setup-miniconda](https://github.com/conda-incubator/setup-miniconda) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/conda-incubator/setup-miniconda/releases) - [Changelog](https://github.com/conda-incubator/setup-miniconda/blob/main/CHANGELOG.md) - [Commits](conda-incubator/setup-miniconda@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: conda-incubator/setup-miniconda dependency-version: 3.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Yuhi Nakamura, AORI, the University of Tokyo. I am a member of Japanese EarthCARE project team.
Prof. Kenta Suzuki and I are developing new simulator code to accommodate Doppler velocity observation by EarthCARE CPR.
I am submitting this request to have my code reviewed and merged into COSP2.
This is an extension of the quickbeam routine to calculate Doppler velocity and spectrum width. Statistics is provided separately for stratiform and convective clouds because vertical air motion is differently obtained in a typical GCM.
I am providing test dataset generated by MIROC6 and python notebooks for visualization.
Could you please review our codes and provide comments so that the new observation can be utilized for evaluating climate models?
Thank you for your all effort on review processes.