Skip to content

src/offline/cable_driver_common.F90: Override cable_user%YearStart to syear for default MetType case#709

Merged
SeanBryan51 merged 1 commit intomainfrom
cable-output-override-yearstart-for-default-mettype
Mar 13, 2026
Merged

src/offline/cable_driver_common.F90: Override cable_user%YearStart to syear for default MetType case#709
SeanBryan51 merged 1 commit intomainfrom
cable-output-override-yearstart-for-default-mettype

Conversation

@SeanBryan51
Copy link
Copy Markdown
Collaborator

@SeanBryan51 SeanBryan51 commented Mar 13, 2026

This change allows cable_user%YearStart to always be the final truth about the start point of the simulation for the default MetType case, consistent with other CABLE configurations.

This change is required to bring in the new parallel I/O output module (#655).

Type of change

  • Refactor

Testing

  • Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line.
2026-03-13 14:01:41,628 - INFO - benchcab.benchcab.py:380 - Running comparison tasks...
2026-03-13 14:01:41,653 - INFO - benchcab.benchcab.py:381 - tasks: 168 (models: 2, sites: 42, science configurations: 4)
2026-03-13 14:04:20,619 - INFO - benchcab.benchcab.py:391 - 0 failed, 168 passed

📚 Documentation preview 📚: https://cable--709.org.readthedocs.build/en/709/

Copy link
Copy Markdown
Contributor

@Whyborn Whyborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like fudging the cable_user%YearEnd, but it seems the way that the site runs set kend makes this unavoidable for now right? If you can think of a good way to not fudge this for now, that would be great, but I can't come up with anything. Happy for it to be merged if you can't think of anything now.

@SeanBryan51
Copy link
Copy Markdown
Collaborator Author

Another way could be to add the statement IF (cable_user%MetType == '') EXIT at the end of the year do loop. I think this should have the same effect

@Whyborn
Copy link
Copy Markdown
Contributor

Whyborn commented Mar 13, 2026

The cable_user%YearEnd would not be set to something meaningful in that instance right? To give it something meaningful, it would have to be modified in the site meteorology reading routine. That whole bit of code should disappear sometime in the next year, so it's probably not worth the time. Given there's not a quick fix way to set YearEnd properly, I reckon just merge it in as is.

@SeanBryan51 SeanBryan51 force-pushed the cable-output-override-yearstart-for-default-mettype branch 2 times, most recently from 3a32b77 to 382c41a Compare March 13, 2026 05:13
@SeanBryan51
Copy link
Copy Markdown
Collaborator Author

Sounds good to me. Thanks Lachlan. I'll go ahead and merge as is.

@SeanBryan51 SeanBryan51 merged commit 42fbda4 into main Mar 13, 2026
9 checks passed
@SeanBryan51 SeanBryan51 deleted the cable-output-override-yearstart-for-default-mettype branch March 13, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants