Skip to content

fix(fits): ignore NaN values when fitting#201

Merged
raimund-schluessler merged 1 commit into
mainfrom
fix/noid/nan-spectrum
Jun 22, 2026
Merged

fix(fits): ignore NaN values when fitting#201
raimund-schluessler merged 1 commit into
mainfrom
fix/noid/nan-spectrum

Conversation

@raimund-schluessler

Copy link
Copy Markdown
Member

The Lorentz fit does not work if the spectrum contains NaN values. This can happen at the beginning or end of the spectrum and might lead e.g. to only one Rayleigh peak to be fitted.

Masking the NaN values fixes this.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.10%. Comparing base (2cf8477) to head (52ad281).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   88.08%   88.10%   +0.01%     
==========================================
  Files          22       22              
  Lines        2476     2479       +3     
==========================================
+ Hits         2181     2184       +3     
  Misses        295      295              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raimund-schluessler raimund-schluessler added this to the 0.12.4 milestone Jun 22, 2026
@raimund-schluessler raimund-schluessler added the bug Something isn't working label Jun 22, 2026
@raimund-schluessler raimund-schluessler merged commit 4950836 into main Jun 22, 2026
26 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/noid/nan-spectrum branch June 22, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant