Skip to content

chore(vitest): bump vitest to v3#375

Merged
gabitoesmiapodo merged 3 commits into
developfrom
fix/tests
Apr 15, 2025
Merged

chore(vitest): bump vitest to v3#375
gabitoesmiapodo merged 3 commits into
developfrom
fix/tests

Conversation

@fernandomg
Copy link
Copy Markdown
Member

Description:

Updated vitest to v3, and adjusted tests that were failing and those really slow

Steps:

~ pnpm install
~ pnpm test

Type of change:

  • New feature
  • Bug fix
  • Breaking change
  • Enhancement
  • Refactoring
  • Chore

How Has This Been Tested?

  • Manual testing
  • Automated tests
  • Other (explain)

Remember to check that:

  • Your code follows the style guidelines of this project
  • You have performed a self-review of your code
  • You have commented your code in hard-to-understand areas
  • You have made corresponding changes to the documentation
  • Your changes generate no new warnings

Screenshots

(Add screenshots or videos to help test this pull request)

@fernandomg fernandomg self-assigned this Apr 11, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dappbooster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 0:17am
docs.dappbooster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 0:17am

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/components/sharedComponents/BigNumberInput.tsx:81

  • The removal of the error clearing call may affect downstream error state handling. Verify that this change aligns with the intended behavior; if error clearing is still necessary, consider adding alternative logic to reset the error state after input updates.
onError?.(null)

Copy link
Copy Markdown
Collaborator

@gabitoesmiapodo gabitoesmiapodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, runs fast, good job.

@gabitoesmiapodo gabitoesmiapodo merged commit 62bb387 into develop Apr 15, 2025
6 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the fix/tests branch April 15, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants