chore(agent-designer): default AGENTS_API_ENABLED on with a kill switch#607
Merged
Conversation
The Agent Designer is complete (contract → surface → resolution → Designer UI → binding reflection), so flip the feature flag from opt-in to default-on, matching the house style for shipped features (scheduled_runs / memorySpaces). - backend `agents_enabled()`: empty-string-safe default-on — unset/empty ⇒ enabled, only the literal "false" disables (was `== "true"`, default off). - CDK `config.agents.enabled`: mirror the memorySpaces/scheduledRuns ternary (`!== 'false'` + context fallback `?? true`), so an unset/empty GitHub Actions var can't silently disable it. - Tests: add the Agents API default-on/empty/kill-switch/context suite to config.test.ts (mirrors Memory Spaces); rename the app-api-environment threading test (no longer "default off"). The `/agents/*` API now ships everywhere; the SPA nav stays preview-gated (system-admin + "Preview" badge) until Assistants are deprecated, so this doesn't broaden user-facing exposure — it just stops the API 404ing per-environment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Agent Designer is complete, so flip
AGENTS_API_ENABLEDfrom opt-in to default ON with a kill switch, matching house style for shipped features (scheduled_runs,memorySpaces).agents_enabled(): empty-string-safe default-on — unset/empty ⇒ enabled, only literal"false"disables.config.agents.enabled: mirror the memorySpaces/scheduledRuns ternary (!== 'false'+ context?? true) so an unset/empty GitHub Actions var can't silently disable it.config.test.ts; renamed the app-api-environment threading test.Scope note: this makes the
/agents/*API available everywhere (stops the per-env 404), but the SPA nav stays preview-gated (system-admin + "Preview" badge), so it does not broaden user-facing exposure. Widening who sees Agents (preview cohort) is separate follow-up work.Verified: infra
tsc+ 77 flag tests green; backend agents route + resolver tests green; default-on behavior probed (unset/empty→on, false→off, true→on).🤖 Generated with Claude Code