chore(memory): default Memory Spaces ON with a kill switch#597
Merged
Conversation
Memory Spaces is a complete feature (CRUD + SPA panel + agent binding), so it should ship enabled for every deployer/forker — opt-out, not opt-in — matching the kbSync / scheduledRuns convention. The table + bucket are already provisioned unconditionally in PlatformStack, so this only flips the runtime MEMORY_SPACES_ENABLED env var; no new infra footprint. - config.ts: memorySpaces.enabled default true (empty/unset workflow var = on, only literal "false" disables); interface + block docs updated - platform.yml: forward CDK_MEMORY_SPACES_ENABLED (kill switch) and CDK_AGENTS_API_ENABLED (per-env enable for the still-default-off /agents surface, so dev can turn it on for dogfooding without a code change) - app-api-environment.ts: comment reflects default-on - config.test.ts: 5 tests locking default-on + kill-switch + context override Agent Designer (AGENTS_API_ENABLED) stays default OFF until the Phase-4 Designer UI ships — a headless /agents surface helps no forker. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default Memory Spaces ON for every deployer (opt-out, not opt-in)
Memory Spaces is a complete feature (CRUD + SPA panel + the agent binding that Phase 3 consumes), so a forker of this repo should get it working out of the box rather than having to discover a flag. This flips it to default ON with a kill switch, matching the
kbSync/scheduledRunsconvention.Zero new infra footprint: the DynamoDB table + S3 bucket are already provisioned unconditionally in
PlatformStack— the flag only toggles the runtimeMEMORY_SPACES_ENABLEDenv var (route mounting). So this is a pure default flip.Changes
config.ts—memorySpaces.enableddefaultstrue; empty/unset workflow var = on, only the literal"false"disables (the empty-string-safe ternary used by kbSync/scheduledRuns). Interface + block docs updated.platform.yml— forwardCDK_MEMORY_SPACES_ENABLED(the kill switch) andCDK_AGENTS_API_ENABLED(so an environment can enable the still-off/agentssurface for dogfooding without a code change).app-api-environment.ts— comment reflects default-on.config.test.ts— 5 tests locking default-on / empty-var-safe / kill switch / context override.Deliberately NOT flipped: Agent Designer
AGENTS_API_ENABLEDstays default off until the Phase-4 Designer UI ships — a headless/agentsAPI with no UI helps no forker. Dev-ai enables it per-environment via the newly-forwardedCDK_AGENTS_API_ENABLEDvariable.Effect on dev-ai
On the next
platform.ymldeploy fromdevelop, dev-ai getsMEMORY_SPACES_ENABLED=trueautomatically (plus the table/bucket, if not already created) — which is the infra prerequisite for the live Oliver dogfood.Testing
tsc --noEmitclean; 437 infra tests pass (incl. the 5 new memory-spaces config tests).🤖 Generated with Claude Code