Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/sdk-coin-polyx/src/lib/transactionBuilderFactory.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BaseTransactionBuilderFactory, NotImplementedError } from '@bitgo/sdk-core';
import { BaseTransactionBuilderFactory } from '@bitgo/sdk-core';
import { BaseCoin as CoinConfig } from '@bitgo/statics';
import { decode } from '@substrate/txwrapper-polkadot';
import { TransferBuilder } from './transferBuilder';
Expand Down Expand Up @@ -153,8 +153,8 @@ export class TransactionBuilderFactory extends BaseTransactionBuilderFactory {
return new V8NominateBuilder(this._coinConfig);
}

getWalletInitializationBuilder(): void {
throw new NotImplementedError(`walletInitialization for ${this._coinConfig.name} not implemented`);
getWalletInitializationBuilder(): RegisterDidWithCDDBuilder {
return this.getRegisterDidWithCDDBuilder();
}

from(rawTxn: string): TransactionBuilder<TxMethod, SupportedTransaction> {
Expand Down
5 changes: 5 additions & 0 deletions modules/sdk-coin-polyx/src/polyx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -367,4 +367,9 @@ export class Polyx extends SubstrateCoin {
},
};
}

/** @inheritDoc */
requiresWalletInitializationTransaction(): boolean {
return true;
}
}
11 changes: 11 additions & 0 deletions modules/sdk-coin-polyx/test/unit/polyx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -360,4 +360,15 @@ describe('Polyx:', function () {
});
});
});

describe('requiresWalletInitializationTransaction', function () {
it('returns true for polyx', function () {
const polyxCoin = bitgo.coin('polyx') as Polyx;
polyxCoin.requiresWalletInitializationTransaction().should.be.true();
});

it('returns true for tpolyx', function () {
baseCoin.requiresWalletInitializationTransaction().should.be.true();
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import should from 'should';
import {
TransactionBuilderFactory,
TransferBuilder,
RegisterDidWithCDDBuilder,
V8TransferBuilder,
V8HexTransferBuilder,
V8TokenTransferBuilder,
Expand Down Expand Up @@ -247,4 +248,24 @@ describe('Tao Transaction Builder Factory', function () {
);
});
});

describe('getWalletInitializationBuilder', function () {
it('returns a RegisterDidWithCDDBuilder instance for tpolyx', function () {
const factory = new TransactionBuilderFactory(coins.get('tpolyx'));
const builder = factory.getWalletInitializationBuilder();
should.ok(
builder instanceof RegisterDidWithCDDBuilder,
'expected RegisterDidWithCDDBuilder from getWalletInitializationBuilder'
);
});

it('returns a RegisterDidWithCDDBuilder instance for polyx', function () {
const factory = new TransactionBuilderFactory(coins.get('polyx'));
const builder = factory.getWalletInitializationBuilder();
should.ok(
builder instanceof RegisterDidWithCDDBuilder,
'expected RegisterDidWithCDDBuilder from getWalletInitializationBuilder'
);
});
});
});
Loading