fix(sdk-coin-bsc,sdk-coin-xdc): harden TSS verify via serializedTxHex - #9403
Open
bitgo-ai-agent-dev[bot] wants to merge 3 commits into
Open
fix(sdk-coin-bsc,sdk-coin-xdc): harden TSS verify via serializedTxHex#9403bitgo-ai-agent-dev[bot] wants to merge 3 commits into
bitgo-ai-agent-dev[bot] wants to merge 3 commits into
Conversation
Contributor
ralph-bitgo
Bot
force-pushed
the
wci-1169-bsc-remove-weak-verifytsstransaction
branch
from
August 3, 2026 10:24
a180e39 to
b505c8b
Compare
bitgo-ai-agent-dev
Bot
force-pushed
the
wci-1169-bsc-remove-weak-verifytsstransaction
branch
from
August 3, 2026 10:24
b505c8b to
b968966
Compare
ralph-bitgo
Bot
force-pushed
the
wci-1169-bsc-remove-weak-verifytsstransaction
branch
from
August 3, 2026 11:11
2e6ca82 to
98afd5e
Compare
bitgo-ai-agent-dev
Bot
changed the title
bitgo-ai-agent-dev
Bot
force-pushed
the
wci-1169-bsc-remove-weak-verifytsstransaction
branch
from
August 3, 2026 11:14
652bec2 to
6c6f12a
Compare
Remove the weak verifyTssTransaction stubs from Bsc/BscToken so they inherit AbstractEthLikeNewCoins validation. Pass serializedTxHex for BSC (and XDC) in ECDSA MPCv1/v2 verify paths because legacy EIP-155 signableHex fails ethereumjs fromSerializedTx. Ticket: WCI-1169 Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the unconditional-return-true stubs from Xdc/XdcToken so they inherit AbstractEthLikeNewCoins transfer validation. Relies on the sdk-core serializedTxHex verify path for legacy EIP-155. Ticket: WCI-1169 Co-authored-by: Cursor <cursoragent@cursor.com>
Marzooqa
force-pushed
the
wci-1169-bsc-remove-weak-verifytsstransaction
branch
from
August 4, 2026 11:42
93797f2 to
67c754e
Compare
Marzooqa
changed the title
Marzooqa
marked this pull request as ready for review
August 4, 2026 12:28
Marzooqa
requested review from
davidkaplanbitgo,
kisslove-dewangan and
parasgarg-bitgo
August 4, 2026 12:28
parasgarg-bitgo
previously approved these changes
Aug 4, 2026
mohammadalfaiyazbitgo
requested changes
Aug 4, 2026
Comment on lines
+814
to
+822
| // For some coins, signableHex is not a parseable transaction. Pass | ||
| // serializedTxHex so verifyTransaction can decode the full tx bytes. | ||
| // - ICP: signableHex is a hash; serializedTxHex is the CBOR-encoded tx. | ||
| // - BSC/XDC (legacy EIP-155): signableHex is RLP(..., chainId, 0, 0), which | ||
| // fails ethereumjs fromSerializedTx EIP-155 v validation; serializedTxHex | ||
| // is the unsigned broadcast form and parses cleanly. | ||
| // For other coins, verification is typically done using just the signableHex. | ||
| const coinFamily = this.baseCoin.getConfig().family; | ||
| if (coinFamily === 'icp' || coinFamily === 'bsc' || coinFamily === 'xdc') { |
Contributor
There was a problem hiding this comment.
this isn't a scalable pattern, we should mark this in a config somewhere. There's CoinFeature we can put it under.
Comment on lines
+955
to
+959
| const coinFamily = this.baseCoin.getConfig().family; | ||
| const isIcp = coinFamily === 'icp'; | ||
| const isLegacyEip155Evm = coinFamily === 'bsc' || coinFamily === 'xdc'; | ||
| const isPreHashed = shouldUsePreHashedSignable(this.baseCoin, unsignedTx); | ||
| if (isIcp || isPreHashed) { | ||
| if (isIcp || isPreHashed || isLegacyEip155Evm) { |
Contributor
There was a problem hiding this comment.
we can refactor this per above.
Replace hard-coded icp/bsc/xdc family checks with CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX on BSC, XDC, and ICP (and their tokens), so new coins can opt in via statics config. Ticket: WCI-1169 Co-authored-by: Cursor <cursoragent@cursor.com>
Marzooqa
force-pushed
the
wci-1169-bsc-remove-weak-verifytsstransaction
branch
from
August 4, 2026 15:58
db2c9f6 to
e3192f7
Compare
parasgarg-bitgo
approved these changes
Aug 4, 2026
mohammadalfaiyazbitgo
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyTssTransactionstubs from BSC/XDC (Bsc/BscToken,Xdc/XdcToken) that returnedtrueafter only shallow presence checks, so they inheritAbstractEthLikeNewCoinstransfer validationserializedTxHex(like ICP) forbsc/xdcduring verify — legacy EIP-155signableHex(RLP withv=chainId) failsethereumjsfromSerializedTx, which is why the stubs existedrecipients[0].data)Why
serializedTxHexTest plan
yarn run unit-test --scope @bitgo/sdk-coin-bscyarn run unit-test --scope @bitgo/sdk-coin-xdcTicket: WCI-1169