refactor(sdk-core): gate serializedTxHex TSS verify via CoinFeature

Marzooqa · cursoragent · Marzooqa · commit db2c9f60d2a7 · 2026-08-04T21:15:51.000+05:30
Replace hard-coded icp/bsc/xdc family checks with CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX on BSC, XDC, and ICP (and their tokens), so new coins can opt in via statics config. Ticket: WCI-1169 Co-authored-by: Cursor <cursoragent@cursor.com>
diff --git a/modules/sdk-core/src/bitgo/utils/tss/ecdsa/ecdsa.ts b/modules/sdk-core/src/bitgo/utils/tss/ecdsa/ecdsa.ts
@@ -51,6 +51,7 @@ import {
 import { BaseEcdsaUtils } from './base';
 import { EncryptionVersion, IRequestTracer } from '../../../../api';
 import { resolveEffectiveTxParams } from '../recipientUtils';
+import { shouldVerifyWithSerializedTxHex } from '../serializedTxHexVerify';
 
 const encryptNShare = ECDSAMethods.encryptNShare;
 
@@ -813,13 +814,9 @@ export class EcdsaUtils extends BaseEcdsaUtils {
 
       // For some coins, signableHex is not a parseable transaction. Pass
       // serializedTxHex so verifyTransaction can decode the full tx bytes.
-      // - ICP: signableHex is a hash; serializedTxHex is the CBOR-encoded tx.
-      // - BSC/XDC (legacy EIP-155): signableHex is RLP(..., chainId, 0, 0), which
-      //   fails ethereumjs fromSerializedTx EIP-155 v validation; serializedTxHex
-      //   is the unsigned broadcast form and parses cleanly.
-      // For other coins, verification is typically done using just the signableHex.
-      const coinFamily = this.baseCoin.getConfig().family;
-      if (coinFamily === 'icp' || coinFamily === 'bsc' || coinFamily === 'xdc') {
+      // Gated by CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX (ICP hash digests,
+      // BSC/XDC legacy EIP-155 RLP with v=chainId, etc.).
+      if (shouldVerifyWithSerializedTxHex(this.baseCoin)) {
         await this.baseCoin.verifyTransaction({
           txPrebuild: { txHex: unsignedTx.serializedTxHex, txInfo: unsignedTx.signableHex },
           txParams: resolveEffectiveTxParams(txRequest, params.txParams),
diff --git a/modules/sdk-core/src/bitgo/utils/tss/ecdsa/ecdsaMPCv2.ts b/modules/sdk-core/src/bitgo/utils/tss/ecdsa/ecdsaMPCv2.ts
@@ -51,6 +51,7 @@ import {
   SignableTransaction,
 } from '../baseTypes';
 import { shouldUsePreHashedSignable } from '../preHashedSignable';
+import { shouldVerifyWithSerializedTxHex } from '../serializedTxHexVerify';
 import { BaseEcdsaUtils } from './base';
 import { EcdsaMPCv2KeyGenSendFn, KeyGenSenderForEnterprise } from './ecdsaMPCv2KeyGenSender';
 import { envRequiresBitgoPubGpgKeyConfig, isBitgoMpcPubKey } from '../../../tss/bitgoPubKeys';
@@ -945,18 +946,12 @@ export class EcdsaMPCv2Utils extends BaseEcdsaUtils {
 
       // For some coins, signableHex is not a parseable transaction. Pass
       // serializedTxHex so verifyTransaction can decode the full tx bytes.
-      // - ICP: signableHex is a hash; serializedTxHex is the CBOR-encoded tx.
+      // - CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX: ICP hash digests,
+      //   BSC/XDC legacy EIP-155 RLP with v=chainId, etc.
       // - Avalanche atomic (FLRP/FLR cross-chain): signableHex is SHA-256(txBody);
       //   serializedTxHex is the PVM/EVM atomic tx (codec prefix 0x0000).
-      // - BSC/XDC (legacy EIP-155): signableHex is RLP(..., chainId, 0, 0), which
-      //   fails ethereumjs fromSerializedTx EIP-155 v validation; serializedTxHex
-      //   is the unsigned broadcast form and parses cleanly.
       // For other coins, signableHex IS the unsigned transaction (e.g. EIP-1559 RLP).
-      const coinFamily = this.baseCoin.getConfig().family;
-      const isIcp = coinFamily === 'icp';
-      const isLegacyEip155Evm = coinFamily === 'bsc' || coinFamily === 'xdc';
-      const isPreHashed = shouldUsePreHashedSignable(this.baseCoin, unsignedTx);
-      if (isIcp || isPreHashed || isLegacyEip155Evm) {
+      if (shouldVerifyWithSerializedTxHex(this.baseCoin) || shouldUsePreHashedSignable(this.baseCoin, unsignedTx)) {
         await this.baseCoin.verifyTransaction({
           txPrebuild: { txHex: unsignedTx.serializedTxHex, txInfo: unsignedTx.signableHex },
           txParams: resolveEffectiveTxParams(txRequest, params.txParams),
diff --git a/modules/sdk-core/src/bitgo/utils/tss/serializedTxHexVerify.ts b/modules/sdk-core/src/bitgo/utils/tss/serializedTxHexVerify.ts
@@ -0,0 +1,12 @@
+import { CoinFeature } from '@bitgo/statics';
+
+import { IBaseCoin } from '../../baseCoin';
+
+/**
+ * Returns true when TSS verifyTransaction should decode serializedTxHex instead of
+ * signableHex (e.g. ICP hash digests, or legacy EIP-155 RLP that fails ethereumjs
+ * fromSerializedTx). Controlled via CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX.
+ */
+export function shouldVerifyWithSerializedTxHex(coin: IBaseCoin): boolean {
+  return coin.getConfig().features.includes(CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX);
+}
diff --git a/modules/statics/src/account.ts b/modules/statics/src/account.ts
@@ -10,6 +10,7 @@ import {
   COSMOS_SIDECHAIN_FEATURES,
   ERC7984_TOKEN_FEATURES,
   TEMPO_FEATURES,
+  XDC_TOKEN_FEATURES,
 } from './coinFeatures';
 
 /**
@@ -3201,7 +3202,7 @@ export function xdcErc20(
   decimalPlaces: number,
   contractAddress: string,
   asset: UnderlyingAsset,
-  features: CoinFeature[] = AccountCoin.DEFAULT_FEATURES,
+  features: CoinFeature[] = XDC_TOKEN_FEATURES,
   prefix = '',
   suffix: string = name.toUpperCase(),
   network: AccountNetwork = Networks.main.xdc,
@@ -3248,7 +3249,7 @@ export function txdcErc20(
   decimalPlaces: number,
   contractAddress: string,
   asset: UnderlyingAsset,
-  features: CoinFeature[] = AccountCoin.DEFAULT_FEATURES,
+  features: CoinFeature[] = XDC_TOKEN_FEATURES,
   prefix = '',
   suffix: string = name.toUpperCase(),
   network: AccountNetwork = Networks.test.xdc,
diff --git a/modules/statics/src/base.ts b/modules/statics/src/base.ts
@@ -617,6 +617,13 @@ export enum CoinFeature {
    * behavior. MUST only be set together with TOKENIZED_EQUITY.
    */
   BITGO_TOKENIZED_EQUITY = 'bitgo-tokenized-equity',
+
+  /**
+   * TSS transaction verification should use serializedTxHex rather than signableHex.
+   * Needed when signableHex is not a parseable transaction (e.g. ICP hash digest, or
+   * legacy EIP-155 RLP with v=chainId that fails ethereumjs fromSerializedTx).
+   */
+  TSS_VERIFY_USE_SERIALIZED_TX_HEX = 'tss-verify-use-serialized-tx-hex',
 }
 
 /**
diff --git a/modules/statics/src/coinFeatures.ts b/modules/statics/src/coinFeatures.ts
@@ -324,15 +324,22 @@ export const BSC_FEATURES = [
   CoinFeature.BULK_TRANSACTION,
   CoinFeature.SHARED_EVM_MESSAGE_SIGNING,
   CoinFeature.ERC20_BULK_TRANSACTION,
+  CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX,
+];
+export const BSC_TOKEN_FEATURES = [
+  ...ACCOUNT_COIN_DEFAULT_FEATURES,
+  CoinFeature.BULK_TRANSACTION,
+  CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX,
 ];
-export const BSC_TOKEN_FEATURES = [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.BULK_TRANSACTION];
 export const BSC_TOKEN_FEATURES_EXCLUDE_SINGAPORE = [
   ...ACCOUNT_COIN_DEFAULT_FEATURES_EXCLUDE_SINGAPORE,
   CoinFeature.BULK_TRANSACTION,
+  CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX,
 ];
 export const BSC_TOKEN_FEATURES_EXCLUDE_MENA_FZE = [
   ...ACCOUNT_COIN_DEFAULT_FEATURES_EXCLUDE_MENA_FZE,
   CoinFeature.BULK_TRANSACTION,
+  CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX,
 ];
 export const STX_FEATURES = [
   ...ACCOUNT_COIN_DEFAULT_FEATURES,
@@ -658,6 +665,7 @@ export const ICP_FEATURES = [
   CoinFeature.SUPPORTS_TOKENS,
   CoinFeature.SHA256_WITH_ECDSA_TSS,
   CoinFeature.REBUILD_ON_CUSTODY_SIGNING,
+  CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX,
 ];
 
 export const STARKNET_FEATURES = [
@@ -758,7 +766,12 @@ export const VET_TOKEN_FEATURES = VET_FEATURES.filter((feature) => feature !== C
 
 export const EVM_NON_EIP1559_FEATURES = [...EVM_FEATURES.filter((feature) => feature !== CoinFeature.EIP1559)];
 
-export const XDC_FEATURES = [...EVM_NON_EIP1559_FEATURES, CoinFeature.ERC20_BULK_TRANSACTION];
+export const XDC_FEATURES = [
+  ...EVM_NON_EIP1559_FEATURES,
+  CoinFeature.ERC20_BULK_TRANSACTION,
+  CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX,
+];
+export const XDC_TOKEN_FEATURES = [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX];
 
 export const SGB_FEATURES = [...EVM_FEATURES, CoinFeature.ERC20_BULK_TRANSACTION];
 
diff --git a/modules/statics/test/unit/coins.ts b/modules/statics/test/unit/coins.ts
@@ -1273,6 +1273,22 @@ describe('ERC20 Bulk Transaction Feature', () => {
   });
 });
 
+describe('TSS Verify Use Serialized Tx Hex Feature', () => {
+  it('should have TSS_VERIFY_USE_SERIALIZED_TX_HEX for coins whose signableHex is not parseable', () => {
+    const coinsNeedingSerializedTxHexVerify = ['bsc', 'tbsc', 'xdc', 'txdc', 'icp', 'ticp'];
+    coinsNeedingSerializedTxHexVerify.forEach((coinName) => {
+      const coin = coins.get(coinName);
+      coin.features.includes(CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX).should.eql(true);
+    });
+  });
+
+  it('should have TSS_VERIFY_USE_SERIALIZED_TX_HEX on BSC and XDC tokens', () => {
+    coins.get('bsc:busd').features.includes(CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX).should.eql(true);
+    coins.get('xdc:usdc').features.includes(CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX).should.eql(true);
+    coins.get('txdc:tmt').features.includes(CoinFeature.TSS_VERIFY_USE_SERIALIZED_TX_HEX).should.eql(true);
+  });
+});
+
 describe('Custody Bulk Withdrawal Features', () => {
   it('should have CUSTODY_BULK_TRANSACTION feature for appropriate coins', () => {
     const custodyBulkWithdrawalCoins = [
