Add ARM clang and bindgen wrappers#1982
Open
NickeZ wants to merge 1 commit into
Open
Conversation
NickeZ
force-pushed
the
nickez/sysroot-wrappers
branch
from
f3132c0 to
6f98e81
Compare
Route CMake cargo invocations through scripts/cargo-wrapper so bindgen gets target-specific clang arguments from one place. The wrapper supplies --target for explicit cargo targets, the ARM sysroot and enum ABI flags for thumb targets, and cortex-m4 soft-float flags for thumbv7 builds. Add a clang wrapper with the same ARM sysroot discovery for non-GCC compiler use. Remove hard-coded bindgen sysroot, target, and ABI flags from Rust build scripts while keeping crate-specific defines there. Update AGENTS.md to document wrapper usage.
NickeZ
force-pushed
the
nickez/sysroot-wrappers
branch
from
6f98e81 to
5f9950e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is in preparation for supporting new targets and clang. Move all target specific flags out of build scripts.
In both cases it is necessary to wrap like this so that it works both for our crates but also for any dependency that generates rust headers or compiles C code.
One limiting factor is that
arm-none-eabi-gcc -print-sysrootdepends on the build machine so it needs to be detected at runtime.Considerations:
To avoid a cargo wrapper, we could introduce a bootstrap/configure step that creates a
~/.cargo/config.tomlfile with the appropriate BINDGEN variable in it.Route CMake cargo invocations through scripts/cargo-wrapper so bindgen
gets target-specific clang arguments from one place. The wrapper
supplies --target for explicit cargo targets, the ARM sysroot and enum
ABI flags for thumb targets, and cortex-m4 soft-float flags for thumbv7
builds.
Add a clang wrapper with the same ARM sysroot discovery for non-GCC
compiler use. Remove hard-coded bindgen sysroot, target, and ABI flags
from Rust build scripts while keeping crate-specific defines there.
Update AGENTS.md to document wrapper usage.