Add auto-shard configuration and manage anndata/dask pins#176
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
da.to_zarrwithda.store(..., lock=False)in pyramid writes (_on_disk_dask_zoom,_on_disk_coarsen) and region slice writes (_ops_slices). Dask >=2025.11'sto_zarrre-derives chunks vianormalize_chunks(chunks="auto", ...)and emits aPerformanceWarning(treated as error by ngio's filterwarnings) when the result is not a multiple of the target's chunks;da.storewrites blocks 1:1.NotImplementedErrorfrom auto-chunking for these dtypes, so they bypass dask and are copied via numpy.auto_shard_zarr_v3together withzarr_write_formatonanndata's global settings via a new_update_anndata_global_settingshelper, so reading/writing tables works correctly when mixing zarr v2 and v3 in the same session on anndata 0.12.Chores
anndatato>=0.12.0,<0.13.0.dask(remove the<2025.11.0upper bound introduced in v0.4.5).Checklist before merging
CHANGELOG.md