Skip to content

Providers should return undefined #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LenKrause wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Providers should return undefined #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bbj-vscode/src/language/bbj-completion-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,19 @@ export class BBjCompletionProvider extends DefaultCompletionProvider {
return super.getCompletion(document, params, cancelToken);
}

protected async getFieldCompletion(document: LangiumDocument, params: CompletionParams): Promise<CompletionList> {
protected async getFieldCompletion(document: LangiumDocument, params: CompletionParams): Promise<CompletionList | undefined> {
// Get cursor position (the # has already been typed)
const offset = document.textDocument.offsetAt(params.position);
const rootNode = document.parseResult.value;

// Find the leaf node at the # character position (cursor is after #, so offset - 1)
if (!rootNode.$cstNode) {
return { items: [], isIncomplete: false };
return undefined;
}
const leafNode = findLeafNodeAtOffset(rootNode.$cstNode, offset - 1);

if (!leafNode) {
return { items: [], isIncomplete: false };
return undefined;
}

// Check if cursor is inside a class method body
Expand All @@ -46,7 +46,7 @@ export class BBjCompletionProvider extends DefaultCompletionProvider {

if (!method || !klass) {
// Not inside a class method — don't provide field completion
return { items: [], isIncomplete: false };
return undefined;
}

// Collect fields from the class and its inheritance hierarchy
Expand Down