feat(headers): allow headers to be defined as a function to return dynamic values#67
Open
whawker wants to merge 1 commit intoAzure:mainfrom
Open
feat(headers): allow headers to be defined as a function to return dynamic values#67whawker wants to merge 1 commit intoAzure:mainfrom
whawker wants to merge 1 commit intoAzure:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Open
|
What about this PR ? |
|
Is this project still maintained? I need this feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using this library as a means to provide a JWT bearer token via the
Authorizationheader to my event source endpoint.However I have found that when the connection is retried (either explicitly, or via the page visibility API), it reuses the headers that were first passed to
fetchEventSource.In my use case, as bearer tokens are short lived, the retry uses a stale bearer token and the retry call fails as unauthorised.
This PR adds the ability to pass
headersas a function, meaning you can pass dynamic values, such as an up-to-date bearer token. It is also backwards compatible with the existing behaviour.Example (using React)