Draft
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the Azure Databricks PowerShell module from API version 2024-05-01 to 2026-01-01. The primary functional change is the addition of a new ComputeMode parameter to the New-AzDatabricksWorkspace cmdlet, which allows users to specify 'Hybrid' or 'Serverless' compute modes when creating workspaces.
Changes:
- API version upgraded from 2024-05-01 to 2026-01-01 across all module components
- Added ComputeMode parameter (Hybrid/Serverless) to workspace creation
- Updated all API model references from Api20240501 to Api202601
- Enhanced test coverage with new scenarios for Serverless and Enhanced Security Compliance (ESC) workspaces
- Updated test infrastructure with second resource group and cleanup logic
Reviewed changes
Copilot reviewed 30 out of 32 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Databricks/Databricks/ChangeLog.md | Added entry for ComputeMode parameter support |
| src/Databricks/Databricks/help/New-AzDatabricksWorkspace.md | Added documentation for ComputeMode parameter |
| src/Databricks/Databricks.Autorest/README.md | Updated API version commit hash and module version |
| src/Databricks/Databricks.Autorest/custom/New-AzDatabricksWorkspace.ps1 | Implemented ComputeMode logic with default to 'Hybrid' |
| src/Databricks/Databricks.Autorest/custom/Update-AzDatabricksWorkspace.ps1 | Updated API model references and breaking change attributes |
| src/Databricks/Databricks.Autorest/custom/Update-AzDatabricksVNetPeering.ps1 | Updated API model references |
| src/Databricks/Databricks.Autorest/custom/New-AzDatabricksWorkspaceProviderAuthorizationObject.ps1 | Updated API model references |
| src/Databricks/Databricks.Autorest/test/AzDatabricksWorkspace.Tests.ps1 | Added Serverless and ESC test scenarios, commented out OutboundNetworkDependencies test |
| src/Databricks/Databricks.Autorest/test/AzDatabricksVNetPeering.Tests.ps1 | Added -NoWait to cleanup operation |
| src/Databricks/Databricks.Autorest/test/utils.ps1 | Added second resource group setup and enabled cleanup |
| src/Databricks/Databricks.Autorest/test/env.json, localEnv.json | Added test environment variables |
| src/Databricks/Databricks.Autorest/test/AzDatabricksVNetPeering.Recording.json | Updated test recordings with new API version |
| src/Databricks/Databricks.Autorest/Properties/AssemblyInfo.cs | Updated assembly version (though inconsistent with README) |
| src/Databricks/Databricks.Autorest/docs/*.md | Updated all help documentation with new API model references |
| src/Databricks/Databricks.Autorest/UX/*.json | Updated API versions in UX configuration |
| src/Databricks/Databricks.Autorest/generate-info.json | Deleted (normal for regeneration) |
Comment on lines
23
to
24
| [assembly: System.Reflection.AssemblyFileVersionAttribute("1.10.1")] | ||
| [assembly: System.Reflection.AssemblyVersionAttribute("1.10.1")] |
There was a problem hiding this comment.
Version mismatch detected: The README.md specifies module-version as "1.11.0", but AssemblyInfo.cs shows version "1.10.1". These version numbers should be consistent. Based on the ChangeLog.md entry for Version 1.11.0, the AssemblyInfo.cs should be updated to match "1.11.0".
Suggested change
| [assembly: System.Reflection.AssemblyFileVersionAttribute("1.10.1")] | |
| [assembly: System.Reflection.AssemblyVersionAttribute("1.10.1")] | |
| [assembly: System.Reflection.AssemblyFileVersionAttribute("1.11.0")] | |
| [assembly: System.Reflection.AssemblyVersionAttribute("1.11.0")] |
Author
There was a problem hiding this comment.
I'm confused if this is supposed to be updated to 1.11.0 if I'm also supposed to remove 1.11.0 Header in the ChangeLog, could I get confirmation on which is correct? As this module-version seems to be set automatically.
src/Databricks/Databricks.Autorest/custom/New-AzDatabricksWorkspace.ps1
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.