[Az.ContainerInstance] Update generation tool version: autorest.powershell v3->v4#28376
[Az.ContainerInstance] Update generation tool version: autorest.powershell v3->v4#28376lijinpei2008 wants to merge 11 commits intomainfrom
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the autorest.powershell generation tool from version 3 to version 4 for the Az.ContainerInstance module. The update modernizes the SDK generation process and updates parameter handling patterns.
- Updates generation tool to leverage autorest.powershell v4 features
- Consolidates parameter sets and introduces new Json input patterns for update operations
- Modernizes identity management patterns with new EnableSystemAssignedIdentity parameter
Reviewed Changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| tools/StaticAnalysis/Exceptions/Az.ContainerInstance/BreakingChangeIssues.csv | Adds breaking change exceptions for property type changes and parameter patterns |
| src/ContainerInstance/ContainerInstance/help/*.md | Updates help documentation with new parameter sets and type references |
| src/ContainerInstance/ContainerInstance.Autorest/test/New-AzContainerGroup.Tests.ps1 | Updates test to use new identity parameter pattern |
| src/ContainerInstance/ContainerInstance.Autorest/examples/*.md | Updates example usage to reflect new identity management approach |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ## SYNOPSIS | ||
| Restarts all containers in a container group in place. | ||
| If container image has updates, new image will be downloaded. | ||
| If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
There appears to be a word missing in this line. It should read 'If container image has updates, new image will be downloaded.' The word 'updates' seems to have been replaced with 'restart' incorrectly.
| If container image has restart new image will be downloaded. | |
| If container image has updates, new image will be downloaded. |
| ## DESCRIPTION | ||
| Restarts all containers in a container group in place. | ||
| If container image has updates, new image will be downloaded. | ||
| If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
Same issue as above - 'restart' should be 'updates' for consistency and correctness.
| If container image has restart new image will be downloaded. | |
| If the container image has updates, the new image will be downloaded. |
| ``` | ||
|
|
||
| This command updates a container group profile using piping. | ||
| This command updates a container group profile using pipeing. |
There was a problem hiding this comment.
The word 'pipeing' is misspelled. It should be 'piping'.
| This command updates a container group profile using pipeing. | |
| This command updates a container group profile using piping. |
| ``` | ||
|
|
||
| This command updates a container group using piping. | ||
| This command updates a container group using pipeing. |
There was a problem hiding this comment.
The word 'pipeing' is misspelled. It should be 'piping'.
| This command updates a container group using pipeing. | |
| This command updates a container group using piping. |
| ``` | ||
|
|
||
| This command updates a container group profile using piping. | ||
| This command updates a container group profile using pipeing. |
There was a problem hiding this comment.
The word 'pipeing' is misspelled. It should be 'piping'.
| This command updates a container group profile using pipeing. | |
| This command updates a container group profile using piping. |
| ``` | ||
|
|
||
| This command updates a container group using piping. | ||
| This command updates a container group using pipeing. |
There was a problem hiding this comment.
The word 'pipeing' is misspelled. It should be 'piping'.
| This command updates a container group using pipeing. | |
| This command updates a container group using piping. |
| ## SYNOPSIS | ||
| Restarts all containers in a container group in place. | ||
| If container image has updates, new image will be downloaded. | ||
| If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
There appears to be a word missing or incorrect in this line. It should read 'If container image has updates, new image will be downloaded.' The word 'updates' seems to have been replaced with 'restart' incorrectly.
| If container image has restart new image will be downloaded. | |
| If container image has updates, new image will be downloaded. |
| ## DESCRIPTION | ||
| Restarts all containers in a container group in place. | ||
| If container image has updates, new image will be downloaded. | ||
| If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
Same issue as above - 'restart' should be 'updates' for consistency and correctness.
| If container image has restart new image will be downloaded. | |
| If the container image has updates, a new image will be downloaded. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
To the author of the pull request, |
|
To the author of the pull request, |
… jinpei/main/ContainerInstance-v4
| ## SYNOPSIS | ||
| Restarts all containers in a container group in place. | ||
| If container image has updates, new image will be downloaded. | ||
| If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
The text "If container image has restart" appears to be a corrupted sentence. The original text "If container image has updates" makes more sense. The word "updates" was incorrectly changed to "restart".
| --> | ||
|
|
||
| ## Upcoming Release | ||
| * Improved user experience and consistency. This may introduce breaking changes. Please refer to [here](https://go.microsoft.com/fwlink/?linkid=2340249). |
There was a problem hiding this comment.
The ChangeLog entry lacks specific details about what changed for users. According to guideline 1000003, ChangeLog entries should be written from the user's perspective and explain what changed and how it affects their usage. The current entry just references a link without describing the actual improvements or breaking changes users will experience.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Preannouncement PR:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.