ci: reorder telemetry message so error (if any) appears first#4396
Open
ci: reorder telemetry message so error (if any) appears first#4396
Conversation
if the ep infos field is incredibly long it would get truncated when sending to app insights, cutting off the error message if any
Contributor
There was a problem hiding this comment.
Pull request overview
Reorders CNI telemetry event message formatting so any error text appears first, reducing the chance it gets truncated by long endpoint info payloads in Application Insights.
Changes:
- In
ADDcompletion telemetry, moved[error]to the beginning of the formatted message before potentially large fields (ipamAddResult,epInfos). - In
DELcompletion telemetry, moved[error]to the beginning of the formatted message for consistency.
camrynl
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
if the ep infos field is incredibly long it would get truncated when sending to app insights, cutting off the error message if any (seen in a few select cases where a single log line can be thousands of characters long)
Issue Fixed:
Requirements:
Notes: