Conversation
hlipsig
requested review from
bennerv,
cadenmarchese,
hawkowl,
jharrington22,
kimorris27,
mociarain,
mrWinston,
rogbas,
sankur-codes,
tiguelu,
tsatam,
wanghaoran1988 and
yjst2012
as code owners
shubhadapaithankar
approved these changes
Jan 30, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hlipsig, shubhadapaithankar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
hlipsig
requested review from
alcasim,
tuxerrante and
ventifus
as code owners
Collaborator
Author
|
The MIWI e2e failure is a flake. Re-running. |
Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.9.5 to 1.10.4. - [Release notes](https://github.com/sigstore/sigstore/releases) - [Commits](sigstore/sigstore@v1.9.5...v1.10.4) --- updated-dependencies: - dependency-name: github.com/sigstore/sigstore dependency-version: 1.10.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…tion sets deletion
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.14.2 to 2.15.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@5ef0c07...a90bcbc) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.15.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 9.3.0 to 9.4.0. - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@42bb470...8fbdead) --- updated-dependencies: - dependency-name: oxsecurity/megalinter dependency-version: 9.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.2.0 to 6.3.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@7a3fe6c...4b73464) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Adds comprehensive domain knowledge for Claude Code including: - API type system internals (internal/external boundary, converter pattern) - Swagger and client generation pipeline with warnings - Frontend request flow with PUT/PATCH handler trace - CosmosDB document lifecycle and dequeue patterns - Viper config flow (test/CI only, not production) - VM size addition checklist - Release process and current version info - CI workflow mapping - Code generation summary (60+ directives) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rename "Core Pattern" to "Cluster Lifecycle" and broaden frontend description to cover all HTTP methods, not just PUT/DELETE - Fix multi-module gotchas: acknowledge replace directive for go build, clarify that go test/go mod tidy still exclude nested modules - Fix unit-test-go claim: it only runs ./... from root, does not separately test pkg/api/ - Fix ClusterConfig types: uses string fields, not vms.VMSize Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pkg/cluster is a lifecycle orchestrator, not the OCP installer itself. The actual installer interaction is delegated to pkg/hive (Hive-based) or pkg/containerinstall (podman wrapper).
Root CLAUDE.md reduced from 488 to 77 lines. Detailed context moved to docs/agent-guides/ with conditional triggers so agents load domain knowledge only when touching relevant areas.
Bumps [webpack](https://github.com/webpack/webpack) from 5.94.0 to 5.105.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md) - [Commits](webpack/webpack@v5.94.0...v5.105.0) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.105.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Caden Marchese <caden.marchese@gmail.com> Co-authored-by: kimorris27 <kimorris@redhat.com> Ref: https://issues.redhat.com/browse/ARO-6444
.. from `make client`.
Collaborator
Author
|
Rebase made me a coauthor on every PR I reviewed lately and made this giant. Closing out to see if I can fix via new branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes
ARO-22749
What this PR does / why we need it:
Deletes MTU installatin time. Feature Flag from RP. But keeps the MTU monitor since it's a valid day2 operation
Test plan for issue:
Removed the MTU related tests (that are not monitors) and ran unit tests locally. All passed. Green e2e Signal is all that's needed.
Is there any documentation that needs to be updated for this PR?
BU will need to inform the 1 customer who was using this that his has been removed, however they were already made aware of this.
How do you know this will function as expected in production?
It should remove a rarely used code path, normal operations should continue.