Skip to content

feat: set evidence-based memory requests for backend and mgmt-agent #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weherdh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: set evidence-based memory requests for backend and mgmt-agent #6324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/deploy/templates/backend.deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ spec:
matchLabels:
app: aro-hcp-backend
serviceAccountName: '{{ .Values.serviceAccount.name }}'
priorityClassName: service-lifecycle-critical
volumes:
- name: backend-service-key-vault
csi:
Expand Down
3 changes: 2 additions & 1 deletion ...ata/zz_fixture_TestHelmTemplate_backend_clstr_scoped_identities_role_set_name_public.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ spec:
matchLabels:
app: aro-hcp-backend
serviceAccountName: 'backend'
priorityClassName: service-lifecycle-critical
volumes:
- name: backend-service-key-vault
csi:
Expand Down Expand Up @@ -239,7 +240,7 @@ spec:
resources:
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
3 changes: 2 additions & 1 deletion ...tdata/zz_fixture_TestHelmTemplate_backend_mi_mock_and_arm_perms_mgr_identities_unset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ spec:
matchLabels:
app: aro-hcp-backend
serviceAccountName: 'backend'
priorityClassName: service-lifecycle-critical
volumes:
- name: backend-service-key-vault
csi:
Expand Down Expand Up @@ -222,7 +223,7 @@ spec:
resources:
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
3 changes: 2 additions & 1 deletion backend/zz_fixture_TestHelmTemplate_dev_westus3_svc_1_aro_hcp_backend_dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ spec:
matchLabels:
app: aro-hcp-backend
serviceAccountName: 'backend'
priorityClassName: service-lifecycle-critical
volumes:
- name: backend-service-key-vault
csi:
Expand Down Expand Up @@ -239,7 +240,7 @@ spec:
resources:
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
6 changes: 5 additions & 1 deletion config/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,10 @@ defaults:
namespace: mgmt-agent
serviceAccountName: mgmt-agent
replicas: 2
resources:
requests:
cpu: 50m
memory: 768Mi
# Kube Applier Controller
kubeApplier:
image:
Expand Down Expand Up @@ -758,7 +762,7 @@ defaults:
resources:
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
limits:
memory: unlimited
azureRuntimeConfig:
Expand Down
6 changes: 5 additions & 1 deletion config/rendered/dev/ci00/centralus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ backend:
memory: unlimited
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
serviceAccountName: backend
logVerbosity: 4
maestro:
Expand Down Expand Up @@ -751,6 +751,10 @@ mgmtAgent:
k8s:
namespace: mgmt-agent
replicas: 2
resources:
requests:
cpu: 50m
memory: 768Mi
serviceAccountName: mgmt-agent
managedIdentityName: mgmt-agent
mgmtKeyVault:
Expand Down
6 changes: 5 additions & 1 deletion config/rendered/dev/ci01/centralus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ backend:
memory: unlimited
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
serviceAccountName: backend
logVerbosity: 4
maestro:
Expand Down Expand Up @@ -751,6 +751,10 @@ mgmtAgent:
k8s:
namespace: mgmt-agent
replicas: 2
resources:
requests:
cpu: 50m
memory: 768Mi
serviceAccountName: mgmt-agent
managedIdentityName: mgmt-agent
mgmtKeyVault:
Expand Down
6 changes: 5 additions & 1 deletion config/rendered/dev/cspr/westus3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ backend:
memory: unlimited
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
serviceAccountName: backend
logVerbosity: 4
maestro:
Expand Down Expand Up @@ -749,6 +749,10 @@ mgmtAgent:
k8s:
namespace: mgmt-agent
replicas: 2
resources:
requests:
cpu: 50m
memory: 768Mi
serviceAccountName: mgmt-agent
managedIdentityName: mgmt-agent
mgmtKeyVault:
Expand Down
6 changes: 5 additions & 1 deletion config/rendered/dev/dev/westus3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ backend:
memory: unlimited
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
serviceAccountName: backend
logVerbosity: 4
maestro:
Expand Down Expand Up @@ -749,6 +749,10 @@ mgmtAgent:
k8s:
namespace: mgmt-agent
replicas: 2
resources:
requests:
cpu: 50m
memory: 768Mi
serviceAccountName: mgmt-agent
managedIdentityName: mgmt-agent
mgmtKeyVault:
Expand Down
6 changes: 5 additions & 1 deletion config/rendered/dev/perf/westus3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ backend:
memory: unlimited
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
serviceAccountName: backend
logVerbosity: 4
maestro:
Expand Down Expand Up @@ -749,6 +749,10 @@ mgmtAgent:
k8s:
namespace: mgmt-agent
replicas: 2
resources:
requests:
cpu: 50m
memory: 768Mi
serviceAccountName: mgmt-agent
managedIdentityName: mgmt-agent
mgmtKeyVault:
Expand Down
6 changes: 5 additions & 1 deletion config/rendered/dev/pers/westus3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ backend:
memory: unlimited
requests:
cpu: 100m
memory: 500Mi
memory: 1Gi
serviceAccountName: backend
logVerbosity: 4
maestro:
Expand Down Expand Up @@ -751,6 +751,10 @@ mgmtAgent:
k8s:
namespace: mgmt-agent
replicas: 2
resources:
requests:
cpu: 50m
memory: 768Mi
serviceAccountName: mgmt-agent
managedIdentityName: mgmt-agent
mgmtKeyVault:
Expand Down
1 change: 1 addition & 0 deletions mgmt-agent/deploy/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ spec:
volumeMounts: []
volumes: []
serviceAccountName: {{ .Values.serviceAccount.name }}
priorityClassName: service-lifecycle-critical
terminationGracePeriodSeconds: 10
nodeSelector:
{{- with .Values.nodeSelector }}
Expand Down
4 changes: 2 additions & 2 deletions mgmt-agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ ksmImage:
deployment:
replicas: "{{ .mgmtAgent.k8s.replicas }}"
requests:
cpu: 50m
memory: 64Mi
cpu: "{{ .mgmtAgent.k8s.resources.requests.cpu }}"
memory: "{{ .mgmtAgent.k8s.resources.requests.memory }}"
Comment thread
weherdh marked this conversation as resolved.
logVerbosity: 2
health:
port: 8080
Expand Down
3 changes: 2 additions & 1 deletion mgmt-agent/zz_fixture_TestHelmTemplate_dev_westus3_mgmt_1_mgmt_agent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,11 @@ spec:
resources:
requests:
cpu: 50m
memory: 64Mi
memory: 768Mi
volumeMounts: []
volumes: []
serviceAccountName: mgmt-agent
priorityClassName: service-lifecycle-critical
terminationGracePeriodSeconds: 10
nodeSelector:
---
Expand Down