Skip to content

feature: Registering Microsoft.ContainerService/IdentityBindingPreview - #6322

Open
rachelvweber wants to merge 1 commit into
Azure:mainfrom
rachelvweber:rawo/enablingIdentityBinding
Open

feature: Registering Microsoft.ContainerService/IdentityBindingPreview#6322
rachelvweber wants to merge 1 commit into
Azure:mainfrom
rachelvweber:rawo/enablingIdentityBinding

Conversation

@rachelvweber

@rachelvweber rachelvweber commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

ARO-28745

What

Registers Microsoft.ContainerService/IdentityBindingPreview preview feature

Why

This is needed for the quota management app quotaizer because the app uses a global identity for managing quota groups at the management group level.

Testing

Ran the e2e tests

Special notes for your reviewer

PR Checklist

  • PR is scoped to a single task (no mixed concerns)
  • Title follows Conventional Commits format
  • Summary explains the "Why" behind the change
  • Linked to relevant ticket/issue
  • Screenshots included (if graph/UI/metrics changes)
  • Self-reviewed the diff
  • CI/CD checks are passing (ignore Tide)
  • Draft PR used for WIP (if applicable)
  • Commit history is clean (rebased/squashed)
  • Tricky code blocks are commented
  • Specific reviewers tagged
  • All comment threads resolved before merge

If E2E tests are included:

  • E2E tests follow Principles of Good E2E Test Case Design
  • If new E2E use case is covered (via a new test or new check/verifier),
    demonstrate that the test is able to detect a defect/error and fail with
    proper error message and logs which communicates nature of the problem.

Copilot AI review requested due to automatic review settings July 29, 2026 23:21
@openshift-ci
openshift-ci Bot requested review from ashishmax31 and roivaz July 29, 2026 23:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the subscription provider feature-registration configuration to include the Azure preview feature Microsoft.ContainerService/IdentityBindingPreview, and regenerates the rendered dev environment configs so the feature is applied in those deployments.

Changes:

  • Added IdentityBindingPreview to the Microsoft.ContainerService feature list under the SVC subscription provider defaults (config/config.yaml).
  • Propagated the change into the rendered dev configs for westus3 and centralus.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
config/config.yaml Adds IdentityBindingPreview to the default SVC subscription provider feature registrations for Microsoft.ContainerService.
config/rendered/dev/pers/westus3.yaml Rendered output includes the new IdentityBindingPreview feature under Microsoft.ContainerService.
config/rendered/dev/perf/westus3.yaml Rendered output includes the new IdentityBindingPreview feature under Microsoft.ContainerService.
config/rendered/dev/dev/westus3.yaml Rendered output includes the new IdentityBindingPreview feature under Microsoft.ContainerService.
config/rendered/dev/cspr/westus3.yaml Rendered output includes the new IdentityBindingPreview feature under Microsoft.ContainerService.
config/rendered/dev/ci01/centralus.yaml Rendered output includes the new IdentityBindingPreview feature under Microsoft.ContainerService.
config/rendered/dev/ci00/centralus.yaml Rendered output includes the new IdentityBindingPreview feature under Microsoft.ContainerService.

@rachelvweber

Copy link
Copy Markdown
Collaborator Author

/retest-required

@weinong weinong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rachelvweber, weinong
Once this PR has been reviewed and has the lgtm label, please assign hbhushan3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rachelvweber
rachelvweber force-pushed the rawo/enablingIdentityBinding branch from 27bdbf4 to df4de88 Compare July 31, 2026 23:11
Copilot AI review requested due to automatic review settings July 31, 2026 23:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@openshift-ci

openshift-ci Bot commented Aug 1, 2026

Copy link
Copy Markdown

@rachelvweber: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-parallel df4de88 link true /test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants