Skip to content

Add DataMap IDs to subscriptionMetadata - #6191

Open
s-fairchild wants to merge 1 commit into
Azure:mainfrom
s-fairchild:s-fairchild/ARO-27752
Open

Add DataMap IDs to subscriptionMetadata#6191
s-fairchild wants to merge 1 commit into
Azure:mainfrom
s-fairchild:s-fairchild/ARO-27752

Conversation

@s-fairchild

Copy link
Copy Markdown

@rachelvweber @stevekuznetsov

What

Add dataMapId fields to subscription metadata.

Why

Required for GDPR pipeline onboarding.
Reference: https://msazure.visualstudio.com/AzureRedHatOpenShift/_git/sdp-pipelines/pullrequest/16510595?path=/hcp/config.schema.json

Testing

Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.

Describe the testing provided. If you did not add tests, provide a clear
justification.

Special notes for your reviewer

PR Checklist

  • PR is scoped to a single task (no mixed concerns)
  • Title follows Conventional Commits format
  • Summary explains the "Why" behind the change
  • Linked to relevant ticket/issue
  • Screenshots included (if graph/UI/metrics changes)
  • Self-reviewed the diff
  • CI/CD checks are passing (ignore Tide)
  • Draft PR used for WIP (if applicable)
  • Commit history is clean (rebased/squashed)
  • Tricky code blocks are commented
  • Specific reviewers tagged
  • All comment threads resolved before merge

If E2E tests are included:

  • E2E tests follow Principles of Good E2E Test Case Design
  • If new E2E use case is covered (via a new test or new check/verifier),
    demonstrate that the test is able to detect a defect/error and fail with
    proper error message and logs which communicates nature of the problem.

Copilot AI review requested due to automatic review settings July 21, 2026 16:42
@openshift-ci
openshift-ci Bot requested review from avollmer-redhat and raelga July 21, 2026 16:42
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown

Hi @s-fairchild. Thanks for your PR.

I'm waiting for a Azure member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the configuration JSON schema (config/config.schema.json) to support additional subscriptionMetadata fields so environments can supply DataMap-related principal IDs required for GDPR pipeline onboarding.

Changes:

  • Add dataMapAgentPrincipalId to subscriptionMetadata.
  • Add dataMapAgentBlueShiftPrincipalId to subscriptionMetadata.

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hlipsig, s-fairchild
Once this PR has been reviewed and has the lgtm label, please assign janboll for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants