Add DataMap IDs to subscriptionMetadata - #6191
Conversation
Required for GDPR pipeline onboarding.
Reference: https://msazure.visualstudio.com/AzureRedHatOpenShift/_git/sdp-pipelines/pullrequest/16510595?path=/hcp/config.schema.json
|
Hi @s-fairchild. Thanks for your PR. I'm waiting for a Azure member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
This PR updates the configuration JSON schema (config/config.schema.json) to support additional subscriptionMetadata fields so environments can supply DataMap-related principal IDs required for GDPR pipeline onboarding.
Changes:
- Add
dataMapAgentPrincipalIdtosubscriptionMetadata. - Add
dataMapAgentBlueShiftPrincipalIdtosubscriptionMetadata.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hlipsig, s-fairchild The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
@rachelvweber @stevekuznetsov
What
Add dataMapId fields to subscription metadata.
Why
Testing
Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.
Describe the testing provided. If you did not add tests, provide a clear
justification.
Special notes for your reviewer
PR Checklist
If E2E tests are included:
demonstrate that the test is able to detect a defect/error and fail with
proper error message and logs which communicates nature of the problem.